Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger refresh on hotswap only for redefined classes #20684

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcollovati
Copy link
Collaborator

Prevent hotswapper to trigger a refresh when the classes are loaded for the first time. Refreshing a view should make sense only if a project class has been modified. The only exception is auto layout classes, that must be applied even if they are not directly references in the component tree.

Fixes #20680
Fixes #20681

Prevent hotswapper to trigger a refresh when the classes are loaded for the
first time. Refreshing a view should make sense only if a project class has
been modified. The only exception is auto layout classes, that must be
applied even if they are not directly references in the component tree.

Fixes #20680
Fixes #20681
Copy link

Test Results

1 159 files  ± 0  1 159 suites  ±0   1h 32m 30s ⏱️ +7s
7 564 tests +11  7 510 ✅ +11  54 💤 ±0  0 ❌ ±0 
7 864 runs   - 25  7 803 ✅  - 25  61 💤 ±0  0 ❌ ±0 

Results for commit 45ef212. ± Comparison against base commit 17295f7.

@mshabarov mshabarov requested a review from caalador December 16, 2024 12:38
Copy link
Contributor

@caalador caalador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work as expected and fixes the issue.

@mcollovati mcollovati marked this pull request as ready for review December 17, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HotSwapAgent refreshes UI after Dialog open Dialog is closing the first time after start when using hotswap
3 participants