Dialog is closing the first time after start when using hotswap #20680
Comments
mcollovati
added a commit
that referenced
this issue
Dec 12, 2024
Prevent hotswapper to trigger a refresh when the classes are loaded for the first time. Refreshing a view should make sense only if a project class has been modified. The only exception is auto layout classes, that must be applied even if they are not directly references in the component tree. Fixes #20680 Fixes #20681
mshabarov
moved this from 🆕 Needs triage
to 🔖 Normal Priority (P2)
in Vaadin Flow bugs & maintenance (Vaadin 10+)
mshabarov
moved this from 🪵Product backlog
to 🔎Iteration reviews
in Vaadin Flow ongoing work (Vaadin 10+)
mshabarov
moved this from 🔖 Normal Priority (P2)
to 🏗 WIP
in Vaadin Flow bugs & maintenance (Vaadin 10+)
github-project-automation
bot
moved this from 🏗 WIP
to ✅ Closed
in Vaadin Flow bugs & maintenance (Vaadin 10+)
github-project-automation
bot
moved this from 🔎Iteration reviews
to Done
in Vaadin Flow ongoing work (Vaadin 10+)
vaadin-bot
pushed a commit
that referenced
this issue
Dec 19, 2024
Prevent hotswapper to trigger a refresh when the classes are loaded for the first time. Refreshing a view should make sense only if a project class has been modified. The only exception is auto layout classes, that must be applied even if they are not directly references in the component tree. Fixes #20680 Fixes #20681
vaadin-bot
pushed a commit
that referenced
this issue
Dec 19, 2024
Prevent hotswapper to trigger a refresh when the classes are loaded for the first time. Refreshing a view should make sense only if a project class has been modified. The only exception is auto layout classes, that must be applied even if they are not directly references in the component tree. Fixes #20680 Fixes #20681
vaadin-bot
added a commit
that referenced
this issue
Dec 19, 2024
…20751) Prevent hotswapper to trigger a refresh when the classes are loaded for the first time. Refreshing a view should make sense only if a project class has been modified. The only exception is auto layout classes, that must be applied even if they are not directly references in the component tree. Fixes #20680 Fixes #20681 Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
added a commit
that referenced
this issue
Dec 19, 2024
…20752) Prevent hotswapper to trigger a refresh when the classes are loaded for the first time. Refreshing a view should make sense only if a project class has been modified. The only exception is auto layout classes, that must be applied even if they are not directly references in the component tree. Fixes #20680 Fixes #20681 Co-authored-by: Marco Collovati <[email protected]>
|
This ticket/PR has been released with Vaadin 24.5.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the bug
When using dialog in a starter application and when using hotswap agent , the dialog (opened from a button click) closes approximately at the time the hot reload happens. The loading indicator is visible when in slow network. This happens only the first time after start but not afterwards. Even refresh does not effect and things work fine.
The issue is replicable in vaadin 24.5.7 and 24.5.8 but not in 24.5.6
Tested in eclipse with JetBrains jbr17_0_1b164.4 and hotswap-agent-2.0.1
Expected behavior
The dialog should not close
Minimal reproducible example
Download a starter and add the basic dialog code from documentation.
Versions
The text was updated successfully, but these errors were encountered: