feat: HMR for translation files #20142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollovati
reviewed
Oct 4, 2024
flow-server/src/main/java/com/vaadin/flow/hotswap/Hotswapper.java
Outdated
Show resolved
Hide resolved
* Clears resource bundle cache on translation resource redeployment * Fires a HMR event to the browser when translations are reloaded Limitation: Only supports DefaultI18NHandler where the paths are known. If you have a custom I18N handler, you might need a custom HMR supporting HotswapListener. For #20118 Requires vaadin/hilla#2795 to fully fix the issue
Artur-
force-pushed
the
clear-bundle-cache
branch
from
611bb29 to
de04118
Compare
Artur-
changed the title
Artur-
commented
Oct 4, 2024
flow-server/src/main/java/com/vaadin/flow/hotswap/Hotswapper.java
Outdated
Show resolved
Hide resolved
|
mcollovati
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Translation file changes are correctly handled by the Flow Hotswapper.
For Flow views, the page is refreshed (no page reload) using PUSH (if enabled) or browser live reload websocket channel.
I couldn't test with Hilla, but the browser live reload correctly forwards the hmr event to the client.
|
Hilla needs a slightly different version of vaadin/hilla#2795 and can be tested as part of that one |
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
* fix: HMR for translation files * Clears resource bundle cache on translation resource redeployment * Fires a HMR event to the browser when translations are reloaded Limitation: Only supports DefaultI18NHandler where the paths are known. If you have a custom I18N handler, you might need a custom HMR supporting HotswapListener. For #20118 Requires vaadin/hilla#2795 to fully fix the issue * format * trigger Flow UIs refresh * flow support * detect correct refresh stragety per UI --------- Co-authored-by: Marco Collovati <[email protected]>
mshabarov
pushed a commit
that referenced
this pull request
Oct 7, 2024
* fix: HMR for translation files * Clears resource bundle cache on translation resource redeployment * Fires a HMR event to the browser when translations are reloaded Limitation: Only supports DefaultI18NHandler where the paths are known. If you have a custom I18N handler, you might need a custom HMR supporting HotswapListener. For #20118 Requires vaadin/hilla#2795 to fully fix the issue * format * trigger Flow UIs refresh * flow support * detect correct refresh stragety per UI --------- Co-authored-by: Artur <[email protected]> Co-authored-by: Marco Collovati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clears resource bundle cache on translation resource redeployment
Fires a HMR event to the browser when translations are reloaded
Limitation: Only supports DefaultI18NHandler where the paths are known. If you have a custom I18N handler, you might need a custom HMR supporting HotswapListener.
For #20118
Requires vaadin/hilla#2795 to fully fix the issue