Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not cache translation bundles in dev mode #20140

Closed
wants to merge 1 commit into from

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Oct 3, 2024

For #20118

@Artur- Artur- marked this pull request as draft October 3, 2024 15:40
Copy link

sonarcloud bot commented Oct 3, 2024

Copy link

github-actions bot commented Oct 3, 2024

Test Results

  907 files   -   232    907 suites   - 232   57m 45s ⏱️ - 14m 56s
4 883 tests  - 2 536  4 821 ✅  - 2 548  49 💤  - 1  1 ❌ +1  12 🔥 +12 
5 198 runs   - 2 535  5 126 ✅  - 2 547  59 💤  - 1  1 ❌ +1  12 🔥 +12 

For more details on these failures and errors, see this check.

Results for commit 6639119. ± Comparison against base commit 1ebd400.

This pull request removes 2536 tests.
com.vaadin.base.devserver.AbstractDevServerRunnerTest ‑ shouldPassEncodedUrlToDevServer
com.vaadin.base.devserver.AbstractDevServerRunnerTest ‑ updateServerStartupEnvironment_preferIpv4_LocalhostIpAddressAddedToProcessEnvironment
com.vaadin.base.devserver.AbstractDevServerRunnerTest ‑ updateServerStartupEnvironment_preferIpv6_LocalhostIpAddressAddedToProcessEnvironment
com.vaadin.base.devserver.BrowserLiveReloadAccessorImplTest ‑ getLiveReload_devMode_contextHasNoReloadInstance_instanceIsCreated
com.vaadin.base.devserver.BrowserLiveReloadAccessorImplTest ‑ getLiveReload_devMode_contextHasReloadInstance_instanceIsReturned
com.vaadin.base.devserver.BrowserLiveReloadAccessorImplTest ‑ getLiveReload_liveReloadDisabled_instanceIsCreated
com.vaadin.base.devserver.BrowserLiveReloadAccessorImplTest ‑ getLiveReload_productionMode_nullIsReturned
com.vaadin.base.devserver.DebugWindowConnectionTest ‑ backwardsCompatibilityClassExists
com.vaadin.base.devserver.DebugWindowConnectionTest ‑ getBackend_HotSwapVaadinIntegrationClassLoaded_returnsHOTSWAP_AGENT
com.vaadin.base.devserver.DebugWindowConnectionTest ‑ getBackend_JRebelClassEventListenerClassLoaded_returnsJREBEL
…

@Artur-
Copy link
Member Author

Artur- commented Oct 4, 2024

Replaced by #20142

@Artur- Artur- closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants