feat: HMR for translations #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artur-
added a commit
to vaadin/flow
that referenced
this pull request
Oct 4, 2024
* Clears resource bundle cache on translation resource redeployment * Fires a HMR event to the browser when translations are reloaded Limitation: Only supports DefaultI18NHandler where the paths are known. If you have a custom I18N handler, you might need a custom HMR supporting HotswapListener. For #20118 Requires vaadin/hilla#2795 to fully fix the issue
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2795 +/- ##
=======================================
Coverage 92.56% 92.56%
=======================================
Files 83 83
Lines 2798 2798
Branches 720 720
=======================================
Hits 2590 2590
Misses 156 156
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mshabarov
pushed a commit
to vaadin/flow
that referenced
this pull request
Oct 7, 2024
* fix: HMR for translation files * Clears resource bundle cache on translation resource redeployment * Fires a HMR event to the browser when translations are reloaded Limitation: Only supports DefaultI18NHandler where the paths are known. If you have a custom I18N handler, you might need a custom HMR supporting HotswapListener. For #20118 Requires vaadin/hilla#2795 to fully fix the issue * format * trigger Flow UIs refresh * flow support * detect correct refresh stragety per UI --------- Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
pushed a commit
to vaadin/flow
that referenced
this pull request
Oct 7, 2024
* fix: HMR for translation files * Clears resource bundle cache on translation resource redeployment * Fires a HMR event to the browser when translations are reloaded Limitation: Only supports DefaultI18NHandler where the paths are known. If you have a custom I18N handler, you might need a custom HMR supporting HotswapListener. For #20118 Requires vaadin/hilla#2795 to fully fix the issue * format * trigger Flow UIs refresh * flow support * detect correct refresh stragety per UI --------- Co-authored-by: Marco Collovati <[email protected]>
mshabarov
pushed a commit
to vaadin/flow
that referenced
this pull request
Oct 7, 2024
* fix: HMR for translation files * Clears resource bundle cache on translation resource redeployment * Fires a HMR event to the browser when translations are reloaded Limitation: Only supports DefaultI18NHandler where the paths are known. If you have a custom I18N handler, you might need a custom HMR supporting HotswapListener. For #20118 Requires vaadin/hilla#2795 to fully fix the issue * format * trigger Flow UIs refresh * flow support * detect correct refresh stragety per UI --------- Co-authored-by: Artur <[email protected]> Co-authored-by: Marco Collovati <[email protected]>
Artur-
commented
Oct 8, 2024
platosha
approved these changes
Oct 16, 2024
|
|
This ticket/PR has been released with Hilla 24.6.0.alpha1 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2175