Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct grammar of error message in @ArrayMaxSize decorator #1752

Closed
wants to merge 102 commits into from
Closed

fix: correct grammar of error message in @ArrayMaxSize decorator #1752

wants to merge 102 commits into from

Conversation

lukeca362
Copy link

Description

Fixes #1242
I have edited the error message to make it more grammatically correct.
Current work around is adding a custom message but it would be good to correct this.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #1242

dependabot bot added 30 commits November 22, 2021 09:06
dependabot bot and others added 20 commits March 14, 2022 09:04
@NoNameProvided NoNameProvided changed the title Fix: Correct grammar of error message - arrayMaxSize fix: correct grammar of error message in @ArrayMaxSize decorator Nov 20, 2022
@NoNameProvided NoNameProvided added the status: superset by another Issue or task being tracked/handled in a different issue. label Nov 20, 2022
@NoNameProvided
Copy link
Member

Fixed in 3aee314.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: superset by another Issue or task being tracked/handled in a different issue.
Development

Successfully merging this pull request may close these issues.

fix: correct typo in error message for @ArrayMaxSize decorator
3 participants