Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct grammar of error message - arrayMaxSize #1243

Closed
wants to merge 0 commits into from
Closed

fix: Correct grammar of error message - arrayMaxSize #1243

wants to merge 0 commits into from

Conversation

lukeca362
Copy link

@lukeca362 lukeca362 commented Aug 11, 2021

Description

Fixes #1242
I have edited the error message to make it more grammatically correct.
Current work around is adding a custom message but it would be good to correct this.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #1242

ccurran01
ccurran01 previously approved these changes Aug 11, 2021
@lukeca362 lukeca362 changed the title Correct grammar of error message - arrayMaxSize fix: Correct grammar of error message - arrayMaxSize Aug 11, 2021
@braaar
Copy link
Member

braaar commented Oct 3, 2022

@lukeca362 could you rebase/merge this and get rid of the irrelevant changes to package.lock?

@lukeca362
Copy link
Author

@braaar When I updated my very outdated fork of this repo the commits were removed so I have created the same PR here:
#1752

@braaar
Copy link
Member

braaar commented Oct 3, 2022

Awesome. I'm tracking the new one in my epic which could bring some maintainer attention to it.

@lukeca362
Copy link
Author

@braaar Legend!

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

fix: correct typo in error message for @ArrayMaxSize decorator
4 participants