Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct typo in error message for @ArrayMaxSize decorator #1242

Closed
lukeca362 opened this issue Aug 11, 2021 · 3 comments
Closed

fix: correct typo in error message for @ArrayMaxSize decorator #1242

lukeca362 opened this issue Aug 11, 2021 · 3 comments
Labels
status: done/released Issue has been completed, no further action is needed. type: fix Issues describing a broken feature.

Comments

@lukeca362
Copy link

lukeca362 commented Aug 11, 2021

Description

The error message doesn't sound right
arrayMaxSize current default message is someProperty must contain not more than X elements

the fix would be someProperty must contain no more than X elements

Minimal code-snippet showcasing the problem

defaultMessage: buildMessage(
          eachPrefix => eachPrefix + '$property must contain not more than $constraint1 elements',
          validationOptions
        ),

Expected behavior

arrayMaxSize default error message:
someProperty must contain no more than X elements

Actual behavior

arrayMaxSize default error message:
someProperty must contain not more than X elements

@lukeca362 lukeca362 added status: needs triage Issues which needs to be reproduced to be verified report. type: fix Issues describing a broken feature. labels Aug 11, 2021
@NoNameProvided NoNameProvided changed the title fix: Default message grammar on arrayMaxSize fix: correct typo in error message for @ArrayMaxSize decorator Nov 20, 2022
@NoNameProvided NoNameProvided added status: fixed Issues with merged PRs, but not released yet. and removed status: needs triage Issues which needs to be reproduced to be verified report. labels Nov 20, 2022
@NoNameProvided
Copy link
Member

Landed in 3aee314.

@NoNameProvided NoNameProvided added status: done/released Issue has been completed, no further action is needed. and removed status: fixed Issues with merged PRs, but not released yet. labels Dec 9, 2022
@NoNameProvided
Copy link
Member

This feature/fix has been released in 0.14.0.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: done/released Issue has been completed, no further action is needed. type: fix Issues describing a broken feature.
2 participants