Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type for locale in @IsAlphanumeric and @IsAlpha decorators #1740

Closed
wants to merge 102 commits into from
Closed

Conversation

ufec
Copy link

@ufec ufec commented Sep 13, 2022

Description

The first parameter of IsAlphanumeric and IsAlpha decorator does not have correct prompt

The effect after modifying the parameter type is as follows:

IsAlphanumeric

IsAlpha

We can clearly see which values can be selected for the first parameter

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • I have run the project locally and verified that there are no errors
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated

Fixes

fixes #1739

dependabot bot added 30 commits November 22, 2021 09:06
dependabot bot and others added 20 commits March 14, 2022 09:04
@braaar
Copy link
Member

braaar commented Oct 3, 2022

This change is already included in #1519, but this PR can be merged on its own, as well.

@NoNameProvided NoNameProvided changed the title fix: The first parameter of IsAlphanumeric and IsAlpha decorator does not have correct prompt fix: add type for locale in @IsAlphanumeric and @IsAlpha decorators Nov 20, 2022
@NoNameProvided
Copy link
Member

Thanks! Landed in 5b0b962 and 72d1eed.

@NoNameProvided NoNameProvided added the status: superset by another Issue or task being tracked/handled in a different issue. label Nov 20, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: superset by another Issue or task being tracked/handled in a different issue.
Development

Successfully merging this pull request may close these issues.

fix: add type for locale in @IsAlphanumeric and @IsAlpha decorators
3 participants