Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epic: implement validators from validator.js #1747

Closed
braaar opened this issue Sep 30, 2022 · 7 comments
Closed

epic: implement validators from validator.js #1747

braaar opened this issue Sep 30, 2022 · 7 comments
Labels
type: discussion Issues discussing any topic.

Comments

@braaar
Copy link
Member

braaar commented Sep 30, 2022 •
edited
Loading

Description

The goal of this issue is to have an overview over presumably uncontroversial feature PRs that implement new validation decorators for validators from the upstream library validator.js

Proposed solution

Review and merge the open PRs that implement such validators

Ready for maintainer review

Need some work still

List of new-ish features in validator.js that don't have a PR yet

(comment if you know any!)
I'll try to look through issues to see if I can spot some.

@jotamorais
@braaar braaar added flag: needs discussion Issues which needs discussion before implementation. type: feature Issues related to new features. labels Sep 30, 2022
@braaar braaar mentioned this issue Sep 30, 2022
Closed
@braaar
Copy link
Member Author

braaar commented Oct 20, 2022

Here's another feature PR that seems ready for review:

@braaar braaar mentioned this issue Oct 20, 2022
Merged
6 tasks
@Kinggodhoon
Copy link
Contributor

Has the project been suspended?

@braaar
Copy link
Member Author

braaar commented Nov 2, 2022

Has the project been suspended?

There has been no word from @NoNameProvided in a while, but we have heard from @jotamorais and @saulotoledo last month, who are members of Typestack. See #1719

@Kinggodhoon
Copy link
Contributor

thank you!

@NoNameProvided NoNameProvided pinned this issue Nov 16, 2022
@NoNameProvided NoNameProvided changed the title feature (epic): implement validators from validator.js epic: implement validators from validator.js Nov 20, 2022
@NoNameProvided
Copy link
Member

Just to chime in, it's not a project goal to implement every single validator from validator.js, so please open an issue before adding an implementation.

@NoNameProvided NoNameProvided added type: discussion Issues discussing any topic. and removed type: feature Issues related to new features. flag: needs discussion Issues which needs discussion before implementation. labels Nov 20, 2022
@braaar
Copy link
Member Author

braaar commented Nov 21, 2022

I think this issue has outlived its usefulness by now

@braaar braaar closed this as completed Nov 21, 2022
@NoNameProvided NoNameProvided unpinned this issue Dec 2, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: discussion Issues discussing any topic.
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NoNameProvided @braaar @Kinggodhoon