Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added IsIPRange validator #1115

Closed
wants to merge 93 commits into from
Closed

feat: added IsIPRange validator #1115

wants to merge 93 commits into from

Conversation

notmedia
Copy link

@notmedia notmedia commented Jun 7, 2021

Description

Added IsIPRange validator

Also, the problem was in typings. I just created PR to DefinitelyTyped/DefinitelyTyped#53666 with fixes. After this PR will be merged, I'll update type deps here and we can merge.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

dependabot bot added 30 commits March 23, 2021 17:40
@notmedia notmedia marked this pull request as ready for review June 8, 2021 21:34
@notmedia
Copy link
Author

notmedia commented Jun 8, 2021

Done, DefinitelyTyped/DefinitelyTyped#53666 was merged.

@notmedia
Copy link
Author

notmedia commented Jun 8, 2021

@NoNameProvided Hi! Can you review this PR please?

@braaar
Copy link
Member

braaar commented Sep 30, 2022

Hi, @notmedia, could you rebase/merge this PR and get rid of the irrelevant changes to package.json and such?

@NoNameProvided NoNameProvided added the status: invalid / expired Issues with no action to take. label Dec 2, 2022
@NoNameProvided
Copy link
Member

Closing this as expired, no response from PR author.

@notmedia notmedia deleted the feat/isiprange branch December 2, 2022 20:38
@github-actions
Copy link

github-actions bot commented Jan 2, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: invalid / expired Issues with no action to take.
Development

Successfully merging this pull request may close these issues.

3 participants