Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add ignore parameter (taken from validatorjs) towards IsAlpha and IsAlphanumeric #1519

Closed
wants to merge 71 commits into from
Closed

fix: Add ignore parameter (taken from validatorjs) towards IsAlpha and IsAlphanumeric #1519

wants to merge 71 commits into from

Conversation

ImranSasudin
Copy link

Description

Add ignore parameter into IsAlpha and IsAlphanumeric to utilize this parameter since it has already been implemented by validatorjs

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #[issue number], fixes #[issue number]

dependabot bot added 30 commits November 22, 2021 09:06
@dependabot
build(deps-dev): bump rollup from 2.60.0 to 2.60.1 (typestack#1415)
3e0b95f
@dependabot
build(deps-dev): bump lint-staged from 12.0.3 to 12.1.2 (typestack#1416)
cbcc0bb
@dependabot
build(deps-dev): bump eslint-plugin-jest from 25.2.4 to 25.3.0 (types…
81f93d0 
…tack#1419)
@dependabot
build(deps-dev): bump @types/node from 16.11.9 to 16.11.10 (typestack…
3d392a7 
…#1420)
@dependabot
build(deps-dev): bump prettier from 2.4.1 to 2.5.0 (typestack#1425)
7adbc06
@dependabot
build(deps-dev): bump rollup from 2.60.1 to 2.60.2 (typestack#1429)
701f9b9
@dependabot
build(deps-dev): bump @types/node from 16.11.10 to 16.11.11 (typestac…
699c906 
…k#1430)
@dependabot
build(deps): bump libphonenumber-js from 1.9.43 to 1.9.44 (typestack#…
3552c4c 
…1434)
@dependabot
build(deps-dev): bump prettier from 2.5.0 to 2.5.1 (typestack#1436)
a35537a
@dependabot
build(deps-dev): bump @types/node from 16.11.11 to 16.11.12 (typestac…
b546ca5 
…k#1437)
@dependabot
build(deps-dev): bump rollup from 2.60.2 to 2.61.0 (typestack#1442)
071fb68
@dependabot
build(deps-dev): bump typescript from 4.5.2 to 4.5.3 (typestack#1446)
645bc8d
@dependabot
build(deps-dev): bump rollup from 2.61.0 to 2.61.1 (typestack#1447)
aad3fea
@dependabot
build(deps-dev): bump typescript from 4.5.3 to 4.5.4 (typestack#1448)
e38968a
@dependabot
build(deps-dev): bump @rollup/plugin-node-resolve from 13.0.6 to 13.1…
e238714 
….1 (typestack#1449)
@dependabot
build(deps-dev): bump @types/node from 16.11.12 to 16.11.13 (typestac…
392eaa6 
…k#1452)
@dependabot
build(deps-dev): bump @types/node from 16.11.13 to 17.0.0 (typestack#…
57cff6d 
…1453)
@dependabot
build(deps-dev): bump @types/node from 17.0.0 to 17.0.1 (typestack#1456)
f560b16
@dependabot
build(deps-dev): bump lint-staged from 12.1.2 to 12.1.3 (typestack#1458)
4e39a04
@dependabot
build(deps-dev): bump @types/node from 17.0.1 to 17.0.2 (typestack#1459)
f3b1daa
@dependabot
build(deps-dev): bump @types/node from 17.0.2 to 17.0.4 (typestack#1461)
d8835a9
@dependabot
build(deps-dev): bump rollup from 2.61.1 to 2.62.0 (typestack#1462)
89280f7
@dependabot
build(deps-dev): bump @types/validator from 13.7.0 to 13.7.1 (typesta…
d9ab052 
…ck#1463)
@dependabot
build(deps-dev): bump @types/node from 17.0.4 to 17.0.5 (typestack#1466)
6b126e3
@dependabot
build(deps-dev): bump lint-staged from 12.1.3 to 12.1.4 (typestack#1465)
03e0f4d
@dependabot
build(deps-dev): bump eslint-plugin-jest from 25.3.0 to 25.3.2 (types…
e34028a 
…tack#1468)
@dependabot
build(deps-dev): bump eslint-plugin-jest from 25.3.2 to 25.3.3 (types…
4d93bde 
…tack#1470)
@dependabot
build(deps-dev): bump @types/jest from 27.0.3 to 27.4.0 (typestack#1472)
7123007
@dependabot
build(deps-dev): bump @rollup/plugin-node-resolve from 13.1.1 to 13.1…
a7fe601 
….2 (typestack#1471)
@dependabot
build(deps-dev): bump @types/node from 17.0.5 to 17.0.8 (typestack#1481)
d59502f
@ImranSasudin
Copy link
Author

It's for this issue #1144

@ImranSasudin ImranSasudin changed the title Fix #1144 : Add ignore parameter (taken from validatorjs) towards IsAlpha and IsAlphanumeric fix: Add ignore parameter (taken from validatorjs) towards IsAlpha and IsAlphanumeric Jan 29, 2022
dependabot bot and others added 15 commits February 1, 2022 09:03
@dependabot
build(deps-dev): bump @types/node from 17.0.13 to 17.0.14 (typestack#…
ad877db 
…1525)
@dependabot
build(deps-dev): bump rollup from 2.66.1 to 2.67.0 (typestack#1526)
8212872
@dependabot
build(deps): bump libphonenumber-js from 1.9.46 to 1.9.47 (typestack#…
1f0028e 
…1528)
@dependabot
build(deps-dev): bump lint-staged from 12.3.2 to 12.3.3 (typestack#1527)
e0ec613
@dependabot
build(deps-dev): bump @types/node from 17.0.14 to 17.0.15 (typestack#…
a5e33c4 
…1530)
@dependabot
build(deps-dev): bump rollup from 2.67.0 to 2.67.1 (typestack#1534)
e5b3e1b
@dependabot
build(deps): bump libphonenumber-js from 1.9.47 to 1.9.48 (typestack#…
14e3955 
…1531)
@dependabot
build(deps-dev): bump eslint-plugin-jest from 26.0.0 to 26.1.0 (types…
42255c8 
…tack#1532)
@dependabot
build(deps-dev): bump ts-node from 10.4.0 to 10.5.0 (typestack#1536)
56b1c24
@dependabot
build(deps-dev): bump @types/node from 17.0.15 to 17.0.16 (typestack#…
dfaae24 
…1537)
@dependabot
build(deps-dev): bump @types/node from 17.0.16 to 17.0.17 (typestack#…
1c51579 
…1541)
@dependabot
build(deps-dev): bump rollup from 2.67.1 to 2.67.2 (typestack#1542)
4017036
@dependabot
build(deps): bump libphonenumber-js from 1.9.48 to 1.9.49 (typestack#…
9a0c7dc 
…1544)
@dependabot
build(deps-dev): bump lint-staged from 12.3.3 to 12.3.4 (typestack#1548)
907bc22
@ImranSasudin
Merge branch 'develop' into develop
fc261bd
@abelland
Copy link

any updates on this?

@ImranSasudin
Copy link
Author

any updates on this?

no update on my side. waiting for review.

This was referenced Oct 3, 2022
Closed
Closed
@NoNameProvided
Copy link
Member

If you are still interested in this change, please re-create the PR on the latest develop branch.

@NoNameProvided NoNameProvided mentioned this pull request Dec 9, 2022
Open
@NoNameProvided
Copy link
Member

This is now tracked in #1842.

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ImranSasudin @abelland @NoNameProvided