fix: pass options to validator in @IsDateString decorator
#1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braaar
previously approved these changes
Aug 17, 2022
|
@braaar you don't have permission to merge? |
|
At this point you might just fork the project. It doesn't seem like @NoNameProvided has any plans to work on this anymore. |
|
I'm hesitant to take it that far. With the amount of stars and weekly downloads this project has, it would be a huge setback and inconvenience for the end users. That's a last resort if the entire Typestack team goes completely AWOL. |
This was referenced Sep 30, 2022
NoNameProvided
force-pushed
the
develop
branch
from
2ef8ff0 to
0da8f89
Compare
NoNameProvided
force-pushed
the
fix-is-date-string
branch
from
064d766 to
0fed8dd
Compare
NoNameProvided
approved these changes
Nov 20, 2022
NoNameProvided
changed the title
@IsDateString decorator
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes calling
@IsDateString({strict: true}). Currently, it doesn't work because the options are not passed to the underlying validator.Fixes
references #1061