fix: passing options when using @IsDateString() #1097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@IsDateString({strict: true})` doesn't work because options are not passed to the validator.
Fixes typestack#1061
NoNameProvided
force-pushed
the
develop
branch
from
acb7de1 to
c6984bb
Compare
braaar
requested changes
Aug 16, 2022
| @@ -24,7 +24,7 @@ export function IsDateString( | |||
| name: IS_DATE_STRING, | |||
| constraints: [options], | |||
| validator: { | |||
| validate: (value, args): boolean => isDateString(value), | |||
| validate: (value, args): boolean => isDateString(value, args.constraints[0]), | |||
There was a problem hiding this comment.
This should work and reads better, no?
Suggested change
| validate: (value, args): boolean => isDateString(value, args.constraints[0]), | |
| validate: (value, args): boolean => isDateString(value, options), |
|
Would you care to rebase/merge this to get rid of merge conflicts and irrelevant changes? |
|
Any reason any it was closed? |
|
I would assume @hakimio is going to make a fresh PR instead of fixing this one. It's a bit cleaner that way, and it makes it easier to pass the unnecessarily strict commit message check |
|
PR #1720 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@IsDateString({strict: true})doesn't work because options are not passed to the validator.Fixes
Fixes #1061