-
Notifications
You must be signed in to change notification settings - Fork 682
Upgrade of Ethereum JS to v6 has introduced technical debt #3693
Comments
We should also go through @jeffsmale90's review on #3656 for some tech debt he's found |
ethereumjs also introduced a new hashing library that is much slower as a default, so we need to make ejs use our current keccak instead. |
We should probably rip out api-extractor and rethink our types approach. |
We should discuss removing our alternative lightweight ethereumjs classes and replace them with the expected ethereumjs classes. While we'd likely take a performance hit, the maintenance overhead of keeping them feels like too much. We have our own block, transactions (transactions and transaction factory), and account classes that we may want to reconsider. |
In tags.ts i added the new tags in two different places... and they are in different orders. It's not an actual problem, but it'll drive me crazy. |
A little something to track the remaining work:
|
Various changes to types and member accessibility in Ethereum JS has required changes to Ganache. In #3656, an amount of technical debt was introduced in order to support the merge.
Including, but not limited to:
any
type assertions@ts-ignore
The text was updated successfully, but these errors were encountered: