-
Notifications
You must be signed in to change notification settings - Fork 682
feat: add support for the merge
hardfork
#3971
Conversation
merge
hardfork
Co-authored-by: David Murdoch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In progress - 77/133 files viewed :/
stack: BN[]; | ||
stack: bigint[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this event expected to be used externally? If so, is this also a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @ganache/console.log
package is pre-1.0, which means every new version is allowed breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe? Thoughts, @davidmurdoch?
Regardless, the console.log package is at version 0.2.0
, so we can break freely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think breaking console package is fine, but if updating the console dep in ganache results in breaking ganache changes, that'd be a breaking change for the ganache
package too right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would. But it doesn't break anything, I don't think 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up @MicaiahReid. I'll test this once the Truffle release ships. Truffle pins @ganache/console.log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LETS DO THIS (after detach mode is released)
This release (re)introduces support for the Merge! In preparation for the merge, our friends at ethereumjs were working hard on a huge new release with quite a few breaking changes. Because we rely so heavily on the work that ethereumjs does, these breaking changes impacted just about every nook and cranny of the Ganache code base. We wanted to get the merge features to our users as soon as possible, while also doing our due diligence to make sure the sweeping changes made by the ethereumjs upgrade don't affect Ganache's stability. With all that in mind, we released Ganache v7.4.4-alpha.0 back in September with support for the Merge. This PR brings that set of features to our stable release.
This introduces a few important changes and features that are worth explaining.
Important Changes
New Feature
The only new feature that could potentially impact our users is the introduction of the
finalized
andsafe
block tags. These can be used witheth_getBlockByNumber
, or any other RPC method that receives a block tag:Note: These new block tags are aliases for the existing
latest
block tag.Fixes #2006, fixes #3693, fixes #3578