This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
build: remove webpack hack #3916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaiahReid
changed the base branch from
tech-debt-dudes
to
fix-build-types2
tenthirtyone
approved these changes
Nov 15, 2022
davidmurdoch
approved these changes
Nov 15, 2022
jeffsmale90
approved these changes
Nov 16, 2022
MicaiahReid
changed the base branch from
fix-build-types2
to
tech-debt-dudes
MicaiahReid
changed the base branch from
tech-debt-dudes
to
fix-build-types2
MicaiahReid
force-pushed
the
remove-webpack-hack
branch
from
4da73e6 to
3a13f08
Compare
MicaiahReid
force-pushed
the
remove-webpack-hack
branch
from
3a13f08 to
b6fdd39
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the main hack in our webpack process that caused Ganache to be dependent upon minification to work.
The downside of this fix is that all ethereumjs codepaths within
if(process.env.DEBUG)scenarios used to be removed completely from our build, while now they remain. Once #2306 over at @ethereumjs is fixed, we can further improve upon this PR.