This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
refactor: rework @ganache/ethereum-address to extend ethereumjs/util's Address
#3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaiahReid
force-pushed
the
combine-ejs-ganache-address
branch
from
51b0f82 to
877524b
Compare
MicaiahReid
force-pushed
the
combine-ejs-ganache-address
branch
from
877524b to
d5be053
Compare
MicaiahReid
commented
Nov 1, 2022
| @@ -93,7 +93,7 @@ export default class BlockManager extends Manager<Block> { | |||
| const extraTxs: GanacheRawBlockTransactionMetaData[] = []; | |||
| json.transactions.forEach((tx, index) => { | |||
| const blockExtra = [ | |||
| Quantity.toBuffer(tx.from), | |||
| Address.toBuffer(tx.from), | |||
There was a problem hiding this comment.
Using Quantity here previously definitely was a bug 😅
davidmurdoch
suggested changes
Nov 7, 2022
src/chains/ethereum/transaction/src/eip1559-fee-market-transaction.ts
Outdated
Show resolved
Hide resolved
MicaiahReid
force-pushed
the
combine-ejs-ganache-address
branch
from
0e7e2f4 to
e3cafc9
Compare
MicaiahReid
force-pushed
the
combine-ejs-ganache-address
branch
from
e3cafc9 to
465f5f1
Compare
davidmurdoch
approved these changes
Nov 8, 2022
jeffsmale90
suggested changes
Nov 9, 2022
jeffsmale90
approved these changes
Nov 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.