Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Add notebook for snowpark example #1188

Open
wants to merge 588 commits into
base: main
Choose a base branch
from

Conversation

sfc-gh-pdharmana
Copy link
Contributor

Items to add to release announcement:

  • Heading: delete this list if this PR does not introduce any changes that need announcing.

Other details that are good to know but need not be announced:

  • There should be something here at least.

piotrm0 and others added 30 commits December 21, 2023 10:40
* first

* typos

* typehint
* import llama only if needed

* use optional imports instead

---------

Co-authored-by: Piotr Mardziel <[email protected]>
* fix

* typo

* don't print external if internal is available
Co-authored-by: Piotr Mardziel <[email protected]>
* adjust docstring for select_context

* langchain select_context, update quickstarts

* undo app name change

* remove dev cell

* generalized langchain select_context (#711)

* generalized langchain select_context

* typo

* typo in string

* update langchain example to pass app in select_context

---------

Co-authored-by: Josh Reini <[email protected]>

* comments, clarity updates to quickstarts

* add lib-independent select_context

* update lc li quickstarts

---------

Co-authored-by: Piotr Mardziel <[email protected]>
* add optional

* bug class_info fix
* update configs

* bugfix

* dont add class info to dicts
* Fix correctness prompt

Fixes #718

* Update base.py
* Bump suggested notebook versions

* Combine notebooks and py files

---------

Co-authored-by: Shayak Sen <[email protected]>
* Bump suggested notebook versions

* Combine notebooks and py files

* Update __init__.py

---------

Co-authored-by: Shayak Sen <[email protected]>
* debug

* display python version

* python version

* PromptTemplate update import

* bad escape fix

* add msg to exception

* pass kwargs in Groundedness

* pass kwargs with GroundTruthAgreement

* give default value to ground_truth_imp

* migrate db on reset
* fix example notebook

* fixes

* remove commented out
* always use prompt instead of messages

* use messages in base

* use prompt in bedrock

* move score to top of cot template, request entire template be used

* remove dev

* add TODO
* update langchain instrumentation page

* include instrumented methods

* llama-index instrumentation updates

* update the overview

* change path to instrumentation overview

* add some more info in appendices and line space

---------

Co-authored-by: Piotr Mardziel <[email protected]>
* add instructions and text wrapping

* format

* clean up github scripts and update README sources

* typo

---------

Co-authored-by: Josh Reini <[email protected]>
* fix

* remove redundant

---------

Co-authored-by: Josh Reini <[email protected]>
* add instructions and text wrapping

* format

* debugging

* making obj arg no longer required

* remove obj and add documentation for WithClassInfo

* remove IPython from most notebooks and organize imports

* fix test errors

* forgot warning

---------

Co-authored-by: Josh Reini <[email protected]>
* update notebooks to test

* rehack

* update langchain requirement

* add core lowerbound
* fix instance check on generic types

* remove original check

---------

Co-authored-by: Piotr Mardziel <[email protected]>
* check for langchain legacy

* few more

* typo

* rephrase

* rephrase
* pass bedrock provider to ground truth eval

* Update bedrock_finetuning_experiments.ipynb

---------

Co-authored-by: Piotr Mardziel <[email protected]>
* first

* temp format

* minor

* more notes

* minor fixes
* first

* temp format

* minor

* more notes

* minor fixes

* more fixes
* bump version 0.20.1

* Update langchain_quickstart.ipynb

* Update llama_index_quickstart.ipynb

* bump py scripts
joshreini1 and others added 22 commits May 14, 2024 11:34
retreivers -> retrievers
* unify groundedness start

* remove groundedness.py

* groundedness nli moves

* remove custom aggregator

* groundedness aggregator to user code

* move agg to trulens side by default (groundedness)

* remove extra code

* remove hf key setting

* remove hf import

* add comment about aggregation for context relevance

* update init

* remove unneeded import

* use generate_score_and_reasons for groundedness internally

* f-strings for groundedness prompts

* docstring

* docstrings formatting

* groundedness reasons template

* remove redundant prompt

* update quickstarts

* llama-index notebooks

* rag triad helper update

* oai assistant nb

* update readme

* models notebooks updates

* iterate nbs

* mongo, pinecone nbs

* update huggingface docstring

* remove outdated docstring selector notes

* more docstring cleaning
* open ai streaming adjustments in cost tracking

* notes

* delete outputs
* Update selecting_components.md

* Update MultiQueryRetrievalLangchain.ipynb

* Update random_evaluation.ipynb

* Update canopy_quickstart.ipynb
* update comprehensiveness + nb

* nb expansion

* fix typo

* meetingbank transcript data

* oss models in app

* test

* benchmarking gpt-3.5-turbo, gpt-4-turbo, and gpt-4o

* update path

* comprehensiveness benchmark

* updated summarization_eval nb

* fix normalization

* show improvement in comprehensiveness feedback functions

---------

Co-authored-by: Daniel <[email protected]>
* version bump

* simpler lc quickstart

* update installs and imports

* update langchain instrumentation docs

* remove groundedness ref from providers.md

* build docs fixes

* remove key cell

* fix docs build

* firx formatting for stock.md

* remove extra spaces

* undo format change

* update docstrings for hugs and base provider

* openai docstring updates

* hugs docstring update

* update context relevance hugs docstring

* more docstring updates

* remove can be changed messages from openai provider docstrings
* add to glossary

* finish some terms
* add httpx to requirements

* undo httpx add

* test add langchain-community

* change langchain-community required version
…nai endpoint (#1154)

* first

* adjust docs

* logic

* add langhain_community to pinecone reqs too

* adjust trubot example with new reqs

* more reqs

* remove extra text

* add langchain_community to a few imports in notebooks

---------

Co-authored-by: Piotr Mardziel <[email protected]>
Co-authored-by: Josh Reini <[email protected]>
Co-authored-by: Josh Reini <[email protected]>
Co-authored-by: Josh Reini <[email protected]>
* fix logo formatting

* fix url

---------

Co-authored-by: Josh Reini <[email protected]>
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 7, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dosubot dosubot bot added the documentation Improvements or additions to documentation label Jun 7, 2024
@joshreini1
Copy link
Contributor

joshreini1 commented Jun 7, 2024

Can you move this to /expositional instead of /quickstart?

Also would be great if this used the standard TruLens QuickStart (with TruCustom) rather than TruBasic

@@ -0,0 +1,280 @@
{
Copy link
Contributor

@joshreini1 joshreini1 Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should include some info about snowpark here and why people care.


Reply via ReviewNB

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally unclear on what the purpose of this notebook is. To show cortex LLM? Logging to snowflake table? Why not cortex feedback provider, cortex search ,etc?

@@ -0,0 +1,280 @@
{
Copy link
Contributor

@joshreini1 joshreini1 Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 'It should look like this in' truncated? What does this mean?


Reply via ReviewNB

@@ -0,0 +1,280 @@
{
Copy link
Contributor

@joshreini1 joshreini1 Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: change to = "sk-..."


Reply via ReviewNB

@sfc-gh-jreini
Copy link
Contributor

This should not be a quickstart. Move to /expositional

@sfc-gh-jreini
Copy link
Contributor

@sfc-gh-pdharmana can we close this? Seems stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.