Update extract_score_and_reasons to work across providers #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the more structured messages should be preferable if available so I'm not sure about just using prompts always. |
joshreini1
changed the title
Good point - updated to use prompt only for bedrock. |
piotrm0
reviewed
Jan 2, 2024
| import json | ||
|
|
||
| body = json.dumps({"inputText": prompt}) | ||
| body = json.dumps({"inputText": prompt, "textGenerationConfig": { | ||
| "maxTokenCount": 4096, |
There was a problem hiding this comment.
Make a task to make these parameters configurable in a future PR?
There was a problem hiding this comment.
@joshreini1 approved but see this note.
There was a problem hiding this comment.
Added a TODO for this
piotrm0
approved these changes
Jan 2, 2024
sfc-gh-dhuang
pushed a commit
that referenced
this pull request
Jun 28, 2024
* always use prompt instead of messages * use messages in base * use prompt in bedrock * move score to top of cot template, request entire template be used * remove dev * add TODO
sfc-gh-chu
pushed a commit
that referenced
this pull request
Sep 25, 2024
* always use prompt instead of messages * use messages in base * use prompt in bedrock * move score to top of cot template, request entire template be used * remove dev * add TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update structured extraction and COT prompting for better results across providers e.g. Bedrock, Ollama
Fixes: #716 and open email with amazon team, possibly: #609