fix(timeline): Clicking first call (second row) in timeline does not display that call's information #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrm0
approved these changes
Dec 22, 2023
sfc-gh-dhuang
pushed a commit
that referenced
this pull request
Jun 28, 2024
Co-authored-by: Piotr Mardziel <[email protected]>
sfc-gh-chu
pushed a commit
that referenced
this pull request
Sep 25, 2024
Co-authored-by: Piotr Mardziel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before fix:
Consider the second row of the timeline like in the screenshot below. It shows the first recorded call of the app (RetrieverQueryEngine.query in the example). Clicking this should display information about that call but instead the ui shows nothing about it and it is as if one clicked on the “All calls” row instead.
After fix:
https://github.com/truera/trulens/assets/36098015/dc837560-2f80-42d1-b205-d7a39d37a272