-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two columns Settings layout #592
Conversation
This is exciting to see happening! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and it works very well!
This looks amazing, is this ready for review or are you still working on it? |
It's ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@menghif This is a huge improvement, and kinda impressive how fast you have been with this!
I haven't read the code yet, but had some UX suggestions:
-
I would prefer to have the selected setting type list item to be highlighted in a bluish shade that is similar to accent color of this application. I think
blue.500
should look good.
-
I noticed that the modal height changes based on what settings type is selected. It would be better if the height of our modal is fixed and we allow the inner body of the modal to scroll. (https://v2.chakra-ui.com/docs/components/modal#modal-overflow-behavior)
-
In the mobile preview, the modal takes full viewport width and touches the edges. It would be better to leave some gap. Maybe try
95vw
?
-
In mobile preview, it would be better if the settings selection control was a dropdown list, so we don't occupy unnecessary real estate on screen.
@menghif can you rebase this to pick up the changes on main? |
Split previous settings into Models and Customization sections Move Web Handlers and Default System Settings to the Settings Modal
Deploying chatcraft-org with Cloudflare Pages
|
I'm loving this. There are some things I think we need to do after this (e.g., split providers from models, show your list of providers on the left under "Providers"), but none of it needs to block this. I'll let you iterate with @Amnish04, but this is really coming along nicely. Thank you! |
@menghif I saw that you are now embedding the settings type selection list into an Accordion on smaller screens. I was wondering if we could hide the already selected item from the drop list, as it feels redundant. Or if possible, we could convert this to a |
We can land this as is and iterate on mobile tweaks incrementally. |
Agree, @menghif file a follow-up for whatever is left and get this in. It's awesome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also agree. We can improve in follow-ups.
Thanks for the improvements!
I was working on this yesterday and made the change to set the Modal's height as fixed and only allow the inner body to scroll. I still have an overflow bug with the Web Handlers body but I can include that in a follow up issue. It's ready for a final review now! |
@menghif land this when you're ready and anything else can happen in follow ups. Amazing work getting this done so fast. |
@menghif this is a huge improvement in my life :) |
Fixes #578
This PR changes the Settings layout by adding a sidebar to the left.
As previously suggested, I split the Settings into one category for Providers, GPT Models and Temperature, then I moved everything else into a "Customization" category.
I moved Web Handlers into Settings and, for consistency, I moved the Default System Prompts as well.
Desktop preview:
Mobile preview: