-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced Image Compression settings should be hidden by default #522
Comments
This would also eliminate the need to rely on |
Can I be assigned to this? |
Done! @tarasglek would you please invite @menghif to the repo so he can do preview branches? @menghif when you get your invite, please do all your branches on this repo vs. your fork using |
@humphd I remember this issue was opened with you not liking how long the modal has become. Its is not directly related this issue, but we can also change the modal overflow to https://v2.chakra-ui.com/docs/components/modal/usage#modal-overflow-behavior But I don't know if you like the scrollbar that would appear right next to modal body. |
@menghif we have another set of issues about redoing the entire settings modal, that you might want to help with as well. That's kind of the right place to fix this; though I'd take a small fix just for this, too. |
@menghif please accept invite, looking forward to this |
I'll send a fix for this one but I can definitely help with the new setting modal if needed! |
@kliu57 Sure I can take it. |
Closing this since the new Settings layout just landed. #592 |
#513 added settings in Preferences Modal for configuring image compression.
This makes the modal too long.
We should have those settings in an Expansion Bar so the user can reveal those settings if needed
The text was updated successfully, but these errors were encountered: