Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Image Compression settings should be hidden by default #522

Closed
Amnish04 opened this issue Mar 23, 2024 · 11 comments
Closed

Advanced Image Compression settings should be hidden by default #522

Amnish04 opened this issue Mar 23, 2024 · 11 comments
Assignees

Comments

@Amnish04
Copy link
Collaborator

#513 added settings in Preferences Modal for configuring image compression.

This makes the modal too long.
image

We should have those settings in an Expansion Bar so the user can reveal those settings if needed

@Amnish04
Copy link
Collaborator Author

This would also eliminate the need to rely on fieldset and weird alignment since the grouping would be handled by an Accordion

https://chakra-ui.com/docs/components/accordion/usage

@mingming-ma mingming-ma self-assigned this Mar 27, 2024
@mingming-ma mingming-ma added this to the Release 1.8 milestone Mar 27, 2024
@mingming-ma mingming-ma modified the milestones: Release 1.8, Release 1.9 Apr 4, 2024
@Rachit1313 Rachit1313 removed this from the Release 1.9 milestone Apr 10, 2024
@mingming-ma mingming-ma removed their assignment Apr 10, 2024
@menghif
Copy link
Collaborator

menghif commented Apr 13, 2024

Can I be assigned to this?

@humphd
Copy link
Collaborator

humphd commented Apr 13, 2024

Done!

@tarasglek would you please invite @menghif to the repo so he can do preview branches?

@menghif when you get your invite, please do all your branches on this repo vs. your fork using menghif/* for the branch name. Then we get preview deployments on CloudFlare for every PR.

@Amnish04
Copy link
Collaborator Author

@humphd I remember this issue was opened with you not liking how long the modal has become.

Its is not directly related this issue, but we can also change the modal overflow to inside and fix its height to whatever looks best to us.

https://v2.chakra-ui.com/docs/components/modal/usage#modal-overflow-behavior

But I don't know if you like the scrollbar that would appear right next to modal body.

@humphd
Copy link
Collaborator

humphd commented Apr 13, 2024

@menghif we have another set of issues about redoing the entire settings modal, that you might want to help with as well. That's kind of the right place to fix this; though I'd take a small fix just for this, too.

@tarasglek
Copy link
Owner

@menghif please accept invite, looking forward to this

@menghif
Copy link
Collaborator

menghif commented Apr 14, 2024

@menghif we have another set of issues about redoing the entire settings modal, that you might want to help with as well. That's kind of the right place to fix this; though I'd take a small fix just for this, too.

I'll send a fix for this one but I can definitely help with the new setting modal if needed!

@humphd
Copy link
Collaborator

humphd commented Apr 14, 2024

I suspect that @kliu57, @Amnish04, and others would appreciate help with the new modal; but I'll get them to confirm that I'm right and they aren't already working on it.

@kliu57
Copy link
Collaborator

kliu57 commented Apr 14, 2024

No one has started work on the new modal yet. @menghif I can assign it you if you're interested. Issue #578 . You can click on the associated issue to see mockup UI.

@menghif
Copy link
Collaborator

menghif commented Apr 14, 2024

@kliu57 Sure I can take it.

@menghif
Copy link
Collaborator

menghif commented Apr 23, 2024

Closing this since the new Settings layout just landed. #592

@menghif menghif closed this as completed Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants