Add Accordion to hide Image Compression section #589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amnish04
reviewed
Apr 16, 2024
Comment on lines
+961
to
967
| <FormControl> | ||
| <Accordion allowToggle> | ||
| <AccordionItem> | ||
| <AccordionButton> | ||
| <FormLabel as="legend" flex="1"> | ||
| Image Compression | ||
| </FormLabel> |
There was a problem hiding this comment.
We should probably not wrap the Accordion in a FormControl.
And since we do not have a fieldset anymore, we should not have a legend either.
We could do something like this as suggested in Chakra Docs
<AccordionButton>
<Box as='span' flex='1' textAlign='left'>
Section 1 title
</Box>
<AccordionIcon />
</AccordionButton>
|
Closing this in favour of the bigger changes in #592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #522
This PR moves the Image Compression section of the User Settings into an Accordion that is hidden by default.