Merge 0.8-dev to master #2731
Merged
Merge 0.8-dev to master #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write item name on Design View on multiple lines Re #2491
We incorrectly rendered the default multidimensional entity class icon if no icon was set for a 0-dimensional entity class. Re #2551
The restored item will be Asterisk when undoing purge. We need to manually ask for all items if we want to process them somehow. Re #2551
- Fix/update tests - Update Changelog - Update User Guide Re #2560
- Added element - Added multidimensional entity Re #2513
Fixes a traceback from element pivot view when entity class is deleted while it is selected. Re #2306
- Affected items are now listed in tables and the tables are tabbed by item type. The previous tree view could not really handle large number of items usability or performance wise. - Affected items are now fetched in a worker thread to keep the window responsive. - Parameter values are now shown like in the Parameter value table in DB editor proper instead of showing the JSON representation. This seems to give a huge performance boost: apparently Qt is not great when it needs to render large amounts of text in a tiny table cell. Re #26062
It is possible that we fetch data that is no longer relevant e.g. when user opens another database in DB editor while the previous one is not yet fully loaded. We now drop data from databases that are not current anymore in compound models to avoid the situation. Re #2709
We can look for the item directly by its id in the mapped table. According to the added benchmark, this is about 4x faster than the previous detour via DatabaseMapping.get_item(). Re #2719
The parent entity class was not properly taken into account when selecting n-dimensional entities deeper in the Entity tree. We now flag the class as selected as well. Re #2719
…ternative tables (#2723)
- Fix animations and item icons on Design View and headless mode - Update CHANGELOG Re Issue #2523
get_data_for_import() in spinedb_api handles conversion from the legacy object/relationship data to entities, so we do not need to "convert" the data via a temporary in-memory database. The temporary database does not contain stuff from the original database like entity classes which caused importing e.g. objects to fail for no apparent reason. Re #2725
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2731 +/- ##
==========================================
+ Coverage 64.03% 65.77% +1.74%
==========================================
Files 199 196 -3
Lines 35909 35879 -30
Branches 6133 6094 -39
==========================================
+ Hits 22993 23599 +606
+ Misses 11684 11017 -667
- Partials 1232 1263 +31 ☔ View full report in Codecov by Sentry. |
|
Unit & execution tests pass. Yay! |
soininen
force-pushed
the
2629_merge_0.8
branch
from
94cc69b to
e3393db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #2692
Checklist before merging