-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 0.8-dev to master #393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to filter items that are None in _advance_query(). Re #287
spinedb_api does not support all database dialects that SqlAlchemy supports. However, you should still be able to use spine_io to import and export to these dialects. To make the other dialects work, we need to add psycopg2 and cx_Oracle to dependencies. Re spine-tools/Spine-Toolbox#2329
SpineOpt particularly is sensible to the order of entities in a class (for determining the sense of connection flows) so we need to keep the right sorting.
To allow subclasses with parsed values to identify situations better.
just "name" is enough.
This is so we don't bring more rows than needed into memory and also to speed up things in some cases.
...we mark the table as purged and then purge stuff as it is fetched by the system. Re #262
This makes it possible to get_items("commit"). Handy for things like Database editor's Commit viewer. Re #2366
from_database() is potentially expensive operation so we should avoid it in ParsedValueBase._something_to_update() if we can. We now check if the types or raw binary blobs differ before parsing the value.
Importer needs methods to create blank mappings. Here they are. Re spine-tools/Spine-Toolbox#2662
Just reformatting, no functional changes. Re spine-tools/Spine-Toolbox#2684
Benchmarks were giving 20x smaller results due to misunderstanding on how the inner_loop parameter of pyperf works. The parameter is no longer used. Also, added two new benchmarks for from_database() in case of Map.
…arse() fromisoformat() makes e.g. constructing DateTime objects from ISO 8601 time stamps ~10x speedier.
The interface is not compatible with 6 anymore with all the 0.8 changes.
It is better if you can store the result file where ever you want just by editing the benchmark script.
soininen
force-pushed
the
toolbox_2629_merge_0.8
branch
from
April 29, 2024 12:10
ac1376f
to
cd995e0
Compare
Toolbox unit tests will run in PR spine-tools/Spine-Toolbox#2731, we do not need modify the GitHub action temporarily for that in this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re spine-tools/Spine-Toolbox#2692
Checklist before merging