Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 0.8-dev to master #393

Merged
merged 415 commits into from
Apr 29, 2024
Merged

Merge 0.8-dev to master #393

merged 415 commits into from
Apr 29, 2024

Conversation

soininen
Copy link
Collaborator

@soininen soininen commented Apr 29, 2024

Re spine-tools/Spine-Toolbox#2692

Checklist before merging

  • Unit tests pass

manuelma and others added 30 commits October 11, 2023 16:22
We need to filter items that are None in _advance_query().

Re #287
spinedb_api does not support all database dialects that SqlAlchemy
supports. However, you should still be able to use spine_io to import
and export to these dialects. To make the other dialects work,
we need to add psycopg2 and cx_Oracle to dependencies.

Re spine-tools/Spine-Toolbox#2329
SpineOpt particularly is sensible to the order of entities
in a class (for determining the sense of connection flows)
so we need to keep the right sorting.
To allow subclasses with parsed values to identify situations better.
This is so we don't bring more rows than needed into memory
and also to speed up things in some cases.
...we mark the table as purged and then purge stuff as it is fetched
by the system.

Re #262
This makes it possible to get_items("commit"). Handy for things like
Database editor's Commit viewer.

Re #2366
soininen and others added 25 commits March 27, 2024 12:22
from_database() is potentially expensive operation so we should
avoid it in ParsedValueBase._something_to_update() if we can.
We now check if the types or raw binary blobs differ before
parsing the value.
Importer needs methods to create blank mappings. Here they are.

Re spine-tools/Spine-Toolbox#2662
Just reformatting, no functional changes.

Re spine-tools/Spine-Toolbox#2684
Benchmarks were giving 20x smaller results due to misunderstanding
on how the inner_loop parameter of pyperf works. The parameter is
no longer used.

Also, added two new benchmarks for from_database() in case of Map.
…arse()

fromisoformat() makes e.g. constructing DateTime objects from ISO 8601
time stamps ~10x speedier.
The interface is not compatible with 6 anymore with all the 0.8 changes.
It is better if you can store the result file where ever you
want just by editing the benchmark script.
@soininen soininen force-pushed the toolbox_2629_merge_0.8 branch from ac1376f to cd995e0 Compare April 29, 2024 12:10
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 83.55030% with 417 lines in your changes are missing coverage. Please review.

Project coverage is 78.25%. Comparing base (828ff38) to head (cd995e0).

Files Patch % Lines
spinedb_api/db_mapping.py 69.02% 117 Missing and 19 partials ⚠️
spinedb_api/mapped_items.py 89.00% 29 Missing and 14 partials ⚠️
spinedb_api/parameter_value.py 77.89% 34 Missing and 8 partials ⚠️
spinedb_api/query.py 77.57% 19 Missing and 5 partials ⚠️
...ccf80441_replace_values_with_reference_to_list_.py 36.11% 22 Missing and 1 partial ⚠️
spinedb_api/db_mapping_query_mixin.py 95.41% 16 Missing and 3 partials ⚠️
spinedb_api/db_mapping_commit_mixin.py 86.27% 11 Missing and 3 partials ⚠️
spinedb_api/export_mapping/export_mapping.py 87.27% 9 Missing and 5 partials ⚠️
spinedb_api/import_mapping/import_mapping.py 90.34% 12 Missing and 2 partials ⚠️
spinedb_api/spine_db_server.py 56.25% 14 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   75.33%   78.25%   +2.92%     
==========================================
  Files          76       75       -1     
  Lines       10985     9511    -1474     
  Branches     2391     2014     -377     
==========================================
- Hits         8275     7443     -832     
+ Misses       2272     1735     -537     
+ Partials      438      333     -105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen
Copy link
Collaborator Author

Toolbox unit tests will run in PR spine-tools/Spine-Toolbox#2731, we do not need modify the GitHub action temporarily for that in this branch.

@soininen soininen merged commit 6e25426 into master Apr 29, 2024
13 of 14 checks passed
@soininen soininen deleted the toolbox_2629_merge_0.8 branch April 29, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants