Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit viewer not showing the affected items #2602

Closed
PiispaH opened this issue Feb 19, 2024 · 1 comment
Closed

Commit viewer not showing the affected items #2602

PiispaH opened this issue Feb 19, 2024 · 1 comment
Assignees
@soininen
Labels
bug Something isn't working DB editor
Milestone
v0.8.0

Comments

@PiispaH
Copy link
Collaborator

PiispaH commented Feb 19, 2024 •
edited
Loading

in #1996:

It seems like the commit history viewer only shows values that have changed

It seems to not even show those values anymore; I changed a few parameter values and the commit viewer doesn't show the changes:
@PiispaH PiispaH added bug Something isn't working DB editor labels Feb 19, 2024
@PiispaH PiispaH added this to the v0.8.0 milestone Feb 19, 2024
@jkiviluo
Copy link
Member

@manuelma Any clue?

@soininen soininen self-assigned this Apr 16, 2024
soininen added a commit that referenced this issue Apr 18, 2024
@soininen
Fix commit viewer not showing any affected items
701309a 
- DB worker's commit cache uses DB ids, not TempIds
- We shouldn't fetch all when getting items for commit, it doesn't
  update commit cache nor make sense for huge databases.

Re #2602
soininen added a commit that referenced this issue Apr 18, 2024
@soininen
Add message to commit viewer that explains why items may be missing
80a0360 
The message hopefully helps users to understand why the viewer
sometimes shows no affected items.

Re #2602
@soininen soininen mentioned this issue Apr 18, 2024
Merged
5 tasks
soininen added a commit that referenced this issue Apr 18, 2024
@soininen
Update Commit viewer screenshot, remove unused images in docs
284ab03 
Re #2602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soininen soininen

Labels
bug Something isn't working DB editor
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
3 participants
@soininen @jkiviluo @PiispaH