Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit History Viewer doesn't show parameter or object/relationship data #1996

Open
DillonJ opened this issue Feb 22, 2023 · 1 comment
Open
Labels
enhancement Enhancement of existing feature
Milestone

Comments

@DillonJ
Copy link
Contributor

DillonJ commented Feb 22, 2023

It seems like the commit history viewer only shows values that have changed, it doesn't show:

  • If the value is new or updated
  • What the old value was if relevant
  • What the parameter is
  • Any of the related entities

Not sure if this was the intended design, but it would be hugely useful if more information could be shown

image

@DillonJ DillonJ added the enhancement Enhancement of existing feature label Feb 22, 2023
@DillonJ DillonJ added this to the V0.7 milestone Feb 22, 2023
@manuelma manuelma modified the milestones: V0.7, Roadmap Feb 22, 2023
@manuelma
Copy link
Collaborator

manuelma commented Feb 22, 2023

This is a known weakness of the current DB schema and I don't think we can do anything by 0.7.

The thing is, every time we modify a record we lose all the previous history by design. This is because the record is just updated in the db together with the new commit id. For this reason, the commit history viewer cannot find the records for previous commits - they're just gone.

Similar when we remove a record.

To be able to show a history, we should add new records with new commits instead of updating existing ones. But this means the tables have the potential to grow very large and we'd need to do something about that as well... There are some plans to handle this in the current proposal for DB schema changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature
Projects
None yet
Development

No branches or pull requests

2 participants