Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining updateDrawableProperties calls #2329

Merged

Conversation

adroitwhiz
Copy link
Contributor

Resolves

Resolves the rest of scratchfoundation/scratch-render#364

Proposed Changes

This PR builds on #2203 and removes the rest of the updateDrawableProperties calls from the VM codebase.

Reason for Changes

As explained in scratchfoundation/scratch-render#469, the new, more specific updateDrawable methods do less unnecessary work, possibly improving performance.

Since the old deprecated updateDrawableProperties method is now unused, this PR allows it to be fully removed from the renderer, reducing the API surface and cleaning up the codebase.

Copy link
Contributor

@fsih fsih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks!

Copy link
Contributor

@cwillisf cwillisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@fsih
Copy link
Contributor

fsih commented Sep 24, 2020

Testing steps: There should be no changes from production

  • Make a say or think bubble and move the sprite around and check that it exists and is drawing in the right position
  • Draw something with the pen extension, it should appear
  • Add the video extension and change video transparency. It should work
  • Take a picture of yourself for a new sprite, and make sure the video turns off after you finish taking a picture, assuming you aren't running the video extension or a virtual meeting

@fsih fsih merged commit 7eabcb8 into scratchfoundation:develop Sep 24, 2020
@adroitwhiz
Copy link
Contributor Author

A note about the first step ("Make a say or think bubble and move the sprite around and check that it exists and is drawing in the right position"): bubbles will not move when you drag a sprite and will only update when you put it back down. This is already filed as scratchfoundation/scratch-gui#1977 and does not need to be filed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants