Remove remaining updateDrawableProperties calls #2329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves the rest of scratchfoundation/scratch-render#364
Proposed Changes
This PR builds on #2203 and removes the rest of the
updateDrawableProperties
calls from the VM codebase.Reason for Changes
As explained in scratchfoundation/scratch-render#469, the new, more specific
updateDrawable
methods do less unnecessary work, possibly improving performance.Since the old deprecated
updateDrawableProperties
method is now unused, this PR allows it to be fully removed from the renderer, reducing the API surface and cleaning up the codebase.