-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new updateDrawable* methods #2203
Use new updateDrawable* methods #2203
Conversation
464a6e6
to
45771a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@mzgoddard Can you resolve the conflicts? Then this will be good to merge |
When this goes in, test by running projects that use position, scale, visibility, rotation center, changing costumes, and graphic effects. Release notes: N/A (rendering should be faster) |
- replace updateDrawableProperties with updateDrawablePosition and other methods - use all of the updateDrawable* methods in updateAllDrawableProperties
45771a4
to
1e9f240
Compare
Test plan: Description: The VM will now make changes to drawable properties (i.e. position, rotation, costume #, graphic effects, etc.) on drawables (i.e. sprites, clones, pen layer, backdrop, etc.) using different methods from the Renderer. Properties:
To test:
|
Resolves
Depends on #2196.
Depends on scratchfoundation/scratch-render#469.
Make VM and Render faster.
Proposed Changes
Reason for Changes
As mentioned in the other PR, using an active tense API in place of a passive tense API allows changes to propagate to Drawables much faster.
Benchmark Data
Refer to tables in scratchfoundation/scratch-render#469.