add Profiler.increment and Profiler.frame #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzgoddard
force-pushed
the
develop-profiler
branch
from
036a919 to
2da1c20
Compare
kchadha
reviewed
Jun 24, 2019
kchadha
reviewed
Jun 24, 2019
kchadha
reviewed
Jun 24, 2019
| if (blockCached._profiler !== runtime.profiler) { | ||
| prepareBlockProfiling(runtime.profiler, blockCached); | ||
| } | ||
| const end = Math.min(i + 1, length); |
There was a problem hiding this comment.
Can you add a comment about what this calculation is? It's difficult to keep track of units and what i and length correspond to.
There was a problem hiding this comment.
// Determine the index that is after the last executed block. `i` is
// currently the block that was just executed. `i + 1` will be the block
// after that. `length` with the min call makes sure we don't try to
// reference an operation outside of the set of operations.
kchadha
reviewed
Jun 24, 2019
kchadha
reviewed
Jun 24, 2019
kchadha
reviewed
Jun 24, 2019
kchadha
reviewed
Jun 24, 2019
kchadha
suggested changes
Jun 24, 2019
mzgoddard
force-pushed
the
develop-profiler
branch
from
30b8806 to
081b6b4
Compare
|
Let profiled code track frames and arguments called by incrementing a counter for a frame id or frame id and argument. This replaces the same counting by recording the call as part of a history of calls and returns. Updating the array for all calls counted takes enough time to bias the profiled run towards less overall executions.
mzgoddard
force-pushed
the
develop-profiler
branch
from
081b6b4 to
d3ae002
Compare
kchadha
approved these changes
Sep 17, 2019
rschamp
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Scratch performance when the profiler is recording.
Proposed Changes
Let profiled code track frames and arguments called by incrementing a counter for a frame id or frame id and argument. This replaces the same counting by recording the call as part of a history of calls and returns. Updating the array for all calls counted takes enough time to bias the profiled run towards less overall executions.
Reason for Changes
Scratch performance has improved to the point again that we need to change how the Profiler records performance to spend more time executing blocks than spending time recording that a block executed.
Benchmark Data
These numbers indicate a large improvement. Take note this improvement is only affecting when profiling is recording. This is a scratch developer facing improvement so we can get a better measure a change will make while developing the change and reviewing the change.