Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #94623

Closed
wants to merge 13 commits into from
Closed

Conversation

Dylan-DPC
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Urgau and others added 13 commits March 3, 2022 12:00

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Add well known values to `--check-cfg` implementation

This pull-request adds well known values for the well known names via `--check-cfg=values()`.

[RFC 3013: Checking conditional compilation at compile time](https://rust-lang.github.io/rfcs/3013-conditional-compilation-checking.html#checking-conditional-compilation-at-compile-time) doesn't define this at all, but this seems a nice improvement.
The activation is done by a empty `values()` (new syntax) similar to `names()` except that `names(foo)` also activate well known names while `values(aa, "aa", "kk")` would not.

As stated this use a different activation logic because well known values for the well known names are not always sufficient.
In fact this is problematic for every `target_*` cfg because of non builtin targets, as the current implementation use those built-ins targets to create the list the well known values.

The implementation is straight forward, first we gather (if necessary) all the values (lazily or not) and then we apply them.

r? ``@petrochenkov``

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ou-se

Clean up the std library's #![feature]s

Signed-off-by: JmPotato <[email protected]>

This is part of rust-lang#87766.

r? ``@m-ou-se``

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
only disable SIMD for doctests in Miri (not for the stdlib build itself)

Also we can enable library/core/tests/simd.rs now, Miri supports enough SIMD for that.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…rts-errors-for-asterisk-wildcard-syntax, r=estebank

Fix invalid `unresolved imports` errors for a single-segment import

closes rust-lang#90248

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ng, r=yaahc

Don't round stack size up for created threads in Windows

Fixes rust-lang#94454

Windows does the rounding itself, so there isn't a need to explicity do the rounding beforehand, as mentioned by ``@ChrisDenton`` in rust-lang#94454

> The operating system rounds up the specified size to the nearest multiple of the system's allocation granularity (typically 64 KB). To retrieve the allocation granularity of the current system, use the [GetSystemInfo](https://docs.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-getsysteminfo) function.

https://docs.microsoft.com/en-us/windows/win32/procthread/thread-stack-size
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Mar 4, 2022
@Dylan-DPC
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Mar 4, 2022

📌 Commit 9fc3109 has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 4, 2022
@bors
Copy link
Contributor

bors commented Mar 4, 2022

⌛ Testing commit 9fc3109 with merge 09be7b1c5e262f4081680ddad11907d2ff46a858...

@rust-log-analyzer
Copy link
Collaborator

The job dist-various-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] gimli test:false 5.158
warning: dropping unsupported crate type `dylib` for target `x86_64-fortanix-unknown-sgx`

error[E0658]: associated type bounds are unstable
   --> library/std/src/sys/sgx/abi/usercalls/alloc.rs:574:24
    |
574 |     I: SliceIndex<[T], Output: UserSafe>,
    |
    = note: see issue #52662 <https://github.com/rust-lang/rust/issues/52662> for more information
    = note: see issue #52662 <https://github.com/rust-lang/rust/issues/52662> for more information
    = help: add `#![feature(associated_type_bounds)]` to the crate attributes to enable
error[E0658]: associated type bounds are unstable
error[E0658]: associated type bounds are unstable
   --> library/std/src/sys/sgx/abi/usercalls/alloc.rs:594:24
    |
594 |     I: SliceIndex<[T], Output: UserSafe>,
    |
    = note: see issue #52662 <https://github.com/rust-lang/rust/issues/52662> for more information
    = note: see issue #52662 <https://github.com/rust-lang/rust/issues/52662> for more information
    = help: add `#![feature(associated_type_bounds)]` to the crate attributes to enable
For more information about this error, try `rustc --explain E0658`.
[RUSTC-TIMING] std test:false 1.994
warning: `std` (lib) generated 1 warning
error: could not compile `std` due to 2 previous errors; 1 warning emitted

@bors
Copy link
Contributor

bors commented Mar 4, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 4, 2022
@Dylan-DPC Dylan-DPC closed this Mar 4, 2022
@Dylan-DPC Dylan-DPC deleted the rollup-kbns8cq branch March 4, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants