Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid unresolved imports errors for a single-segment import #94595

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Mar 4, 2022

closes #90248

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 4, 2022
@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2022
@TaKO8Ki TaKO8Ki changed the title Fix invalid unresolved imports errors the asterisk wildcard syntax causes Fix invalid unresolved imports errors for a one segment import Mar 4, 2022
@TaKO8Ki TaKO8Ki changed the title Fix invalid unresolved imports errors for a one segment import Fix invalid unresolved imports errors for single segment import Mar 4, 2022
@TaKO8Ki TaKO8Ki changed the title Fix invalid unresolved imports errors for single segment import Fix invalid unresolved imports errors for a single segment import Mar 4, 2022
@TaKO8Ki TaKO8Ki changed the title Fix invalid unresolved imports errors for a single segment import Fix invalid unresolved imports errors for a single-segment import Mar 4, 2022
@TaKO8Ki TaKO8Ki marked this pull request as draft March 4, 2022 04:27
@TaKO8Ki TaKO8Ki force-pushed the fix-invalid-unresolved-imports-errors-for-asterisk-wildcard-syntax branch from 09f3d8e to 068a233 Compare March 4, 2022 05:09
@TaKO8Ki TaKO8Ki marked this pull request as ready for review March 4, 2022 05:11
@estebank
Copy link
Contributor

estebank commented Mar 4, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Mar 4, 2022

📌 Commit 068a233 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 4, 2022
…rts-errors-for-asterisk-wildcard-syntax, r=estebank

Fix invalid `unresolved imports` errors for a single-segment import

closes rust-lang#90248
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#94362 (Add well known values to `--check-cfg` implementation)
 - rust-lang#94577 (only disable SIMD for doctests in Miri (not for the stdlib build itself))
 - rust-lang#94595 (Fix invalid `unresolved imports` errors for a single-segment import)
 - rust-lang#94596 (Delay bug in expr adjustment when check_expr is called multiple times)
 - rust-lang#94618 (Don't round stack size up for created threads in Windows)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f27466d into rust-lang:master Mar 5, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 5, 2022
@TaKO8Ki TaKO8Ki deleted the fix-invalid-unresolved-imports-errors-for-asterisk-wildcard-syntax branch March 5, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"use not_existing_crate:*;" causes invalid "unresolved imports" compile errors
5 participants