Tracking issue for organizing the standard library's #![feature]s #87766

m-ou-se · 2021-08-04T16:34:11Z

The standard libraries use a lot of #![feature]s. We should organize them a bit and make sure it's acceptable for all of them to be used in the way they are.

It'd be nice to split them in language and library features. For the language features, we should check with the relevant team(s) if it's okay that we're using the feature in the library, and document with which of them we need to be extra careful and what their pitfalls are.

There's also a few features enabled that are no longer in use. We should remove those attributes.

Categorize and clean up features
- core: Core features cleanup #87768
- alloc: Alloc features cleanup #87769
- std
- other libraries
Make an overview of used language features
Discuss those language features and their uses with the relevant team(s)
Document stuff for future contributors and reviewers

The text was updated successfully, but these errors were encountered:

…olnay Core features cleanup This sorts and categorizes the `#![features]` in `core` and removes unused ones. This is part of rust-lang#87766 The following feature attributes were unnecessary and are removed: ```diff // Library features: -#![feature(bool_to_option)] -#![feature(char_indices_offset)] -#![feature(pin_deref_mut)] -#![feature(str_split_as_str)] -#![feature(str_split_inclusive_as_str)] // Language features: -#![feature(arbitrary_self_types)] -#![feature(custom_inner_attributes)] -#![feature(nll)] ```

…aahc,dtolnay Alloc features cleanup This sorts and categorizes the `#![features]` in `alloc` and removes unused ones. This is part of rust-lang#87766 The following feature attributes were unnecessary and are removed: ```diff // Library features: -#![feature(cow_is_borrowed)] -#![feature(maybe_uninit_uninit_array)] -#![feature(slice_partition_dedup)] // Language features: -#![feature(arbitrary_self_types)] -#![feature(auto_traits)] -#![feature(box_patterns)] -#![feature(decl_macro)] -#![feature(nll)] ```

JmPotato · 2022-03-03T06:58:33Z

Hi! I noticed that it had been a while since the last update of this issue, so I took some time to clean up the std library's ![feature]s. Could you please take a look at #94546, thx!

…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? `@m-ou-se`

…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? ``@m-ou-se``

…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? ```@m-ou-se```

…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? ````@m-ou-se````

…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? `````@m-ou-se`````

…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? ``````````````````@m-ou-se``````````````````

…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? `````````````````````@m-ou-se`````````````````````

…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? `@m-ou-se`

…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? ``@m-ou-se``

…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? `@m-ou-se`

Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? `@m-ou-se`

m-ou-se added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 4, 2021

m-ou-se self-assigned this Aug 4, 2021

the8472 added the A-technical-debt Area: Internal cleanup work label Feb 8, 2022

JmPotato mentioned this issue Mar 3, 2022

Clean up the std library's #![feature]s #94546

Merged

bors added a commit to rust-lang-ci/rust that referenced this issue Mar 5, 2022

Auto merge of rust-lang#94546 - JmPotato:std-features-cleanup, r=m-ou-se

86067bb

Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? `@m-ou-se`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking issue for organizing the standard library's #![feature]s #87766

Tracking issue for organizing the standard library's #![feature]s #87766

m-ou-se commented Aug 4, 2021 •

edited by bjorn3

Loading

JmPotato commented Mar 3, 2022

Tracking issue for organizing the standard library's #![feature]s #87766

Tracking issue for organizing the standard library's #![feature]s #87766

Comments

m-ou-se commented Aug 4, 2021 • edited by bjorn3 Loading

JmPotato commented Mar 3, 2022

m-ou-se commented Aug 4, 2021 •

edited by bjorn3

Loading