-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add regression test for #36168 #37919
Conversation
Travis failue does not look legit: https://api.travis-ci.org/jobs/177737188/log.txt?deansi=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me modulo the misleading comment and maybe the redundant impl.
|
||
extern crate point; | ||
|
||
/// A fn item that calls (public) methods on `Point` from the same impl which changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since no impl is changed in this test case, really, I think one impl would be enough.
d08a8fe
to
72fbf9f
Compare
@bors r=mw |
📌 Commit 72fbf9f has been approved by |
@bors rollup |
add regression test for rust-lang#36168 Fixes rust-lang#36168 r? @michaelwoerister
add regression test for rust-lang#36168 Fixes rust-lang#36168 r? @michaelwoerister
Fixes #36168
r? @michaelwoerister