Rollup of 15 pull requests #38148
Merged
Rollup of 15 pull requests #38148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use syntax::ast::Name; is a reexport of syntax::symbol::Symbol(u32);
For a given file
```
trait Foo {
fn bar(&self);
}
pub struct FooConstForMethod;
impl Foo for FooConstForMethod {
const bar: u64 = 1;
}
```
show
```
error[E0323]: item `bar` is an associated const, which doesn't match its trait `Foo`
```
instead of
```
error[E0323]: item `bar` is an associated const, which doesn't match its trait `<FooConstForMethod as Foo>`
```
This causes us to dump a bunch of has information to stdout that can be useful in tracking down incremental compilation invalidations, particularly across crates.
Make clear that items must be definitions, and add missing extern block
Add missing examples for Ipv6Addr r? @steveklabnik cc @frewsxcv
add regression test for rust-lang#36168 Fixes rust-lang#36168 r? @michaelwoerister
…ewsxcv Add part of missing UdpSocket's urls and examples r? @frewsxcv
Refactor one_bound_for_assoc_type to take an Iterator instead of Vec I doubt the performance implications will be serious, but it will avoid allocating one-element Vecs for the successful case (and avoid allocating vecs at all for any case, too). `--stage 2` tests passed locally.
Fix verify.rs Finishing d2f8fb0 from @jseyfried
Show `Trait` instead of `<Struct as Trait>` in E0323
For a given file
```
trait Foo {
fn bar(&self);
}
pub struct FooConstForMethod;
impl Foo for FooConstForMethod {
const bar: u64 = 1;
}
```
show
```
error[E0323]: item `bar` is an associated const, which doesn't match its trait `Foo`
```
instead of
```
error[E0323]: item `bar` is an associated const, which doesn't match its trait `<FooConstForMethod as Foo>`
```
Fix rust-lang#37618
bootstrap/README: fix small typo
Add missing examples for IpAddr enum r? @frewsxcv
…test-on-aarch64, r=alexcrichton debuginfo: Ignore macro-stepping test on aarch64 See rust-lang#37225. r? @alexcrichton
Add cloned example for Option r? @frewsxcv
…nfo, r=nikomatsakis incr.comp.: Add more output to -Z incremental-info. Also makes sure that all output from `-Z incremental-info` is prefixed with `incremental:` for better grep-ability. r? @nikomatsakis
Minor fix to testing concurrency section
… r=michaelwoerister add a `-Z incremental-dump-hash` flag This causes us to dump a bunch of has information to stdout that can be useful in tracking down incremental compilation invalidations, particularly across crates.
Update items section in reference Make clear that items must be definitions, and add missing extern block
…wsxcv Add Component examples r? @frewsxcv
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r=frewsxcv p=100 |
|
📌 Commit 2e038ed has been approved by |
bors
added a commit
that referenced
this pull request
Dec 3, 2016
This was referenced Dec 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traitinstead of<Struct as Trait>in E0323 #38065, bootstrap/README: fix small typo #38073, Add missing examples for IpAddr enum #38077, debuginfo: Ignore macro-stepping test on aarch64 #38089, Add cloned example for Option #38090, incr.comp.: Add more output to -Z incremental-info. #38096, Minor fix to testing concurrency section #38112, add a-Z incremental-dump-hashflag #38113, Update items section in reference #38130, Add Component examples #38141