Rollup of 8 pull requests #38106
Closed
Rollup of 8 pull requests #38106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dns2utf8
commented
Dec 1, 2016
dns2utf8
commented
- Successful merges: Add missing examples for Ipv6Addr #37859, add regression test for #36168 #37919, Add part of missing UdpSocket's urls and examples #38020, Refactor one_bound_for_assoc_type to take an Iterator instead of Vec #38028, Fix verify.rs #38029, bootstrap/README: fix small typo #38073, Add missing examples for IpAddr enum #38077, Add cloned example for Option #38090
- Failed merges:
use syntax::ast::Name; is a reexport of syntax::symbol::Symbol(u32);
Add missing examples for Ipv6Addr r? @steveklabnik cc @frewsxcv
add regression test for rust-lang#36168 Fixes rust-lang#36168 r? @michaelwoerister
…ewsxcv Add part of missing UdpSocket's urls and examples r? @frewsxcv
Refactor one_bound_for_assoc_type to take an Iterator instead of Vec I doubt the performance implications will be serious, but it will avoid allocating one-element Vecs for the successful case (and avoid allocating vecs at all for any case, too). `--stage 2` tests passed locally.
Fix verify.rs Finishing d2f8fb0 from @jseyfried
bootstrap/README: fix small typo
Add missing examples for IpAddr enum r? @frewsxcv
Add cloned example for Option r? @frewsxcv
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
Rollup looks good. Is this ok? |
|
📌 Commit 0c28d5d has been approved by |
|
⌛ Testing commit 0c28d5d with merge fb24878... |
|
@bors: retry force clean
|
|
⌛ Testing commit 0c28d5d with merge ec35783... |
|
Oh, the button just worked so I guessed 😉 I guess only collaborators have the right to r+? |
|
💔 Test failed - auto-win-gnu-32-opt |
|
Ah, too bad it failed. So what do we next? Can I edit this PR and try to fix it or should I close it? |
|
Yes, only collaborators can r+ and yes, please close it. |
|
Sorry for the interruption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.