Add setuptools as build dependency on Python 3.12+ #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.12 implements PEP 632 to remove distutils from the standard library, but Pendulum 2.x's build script depends on the module to build the C extension. This implements the lowest effort solution, adding setuptools as a build dependency on Python 3.12 and later, which injects distutils automatically back into the environment for compatibility.
|
yes please! |
|
hi can we get a merge on this PR and maybe a release? Thanks! cc @sdispater @Secrus |
devraj
added a commit
to anomaly/lab-python-server
that referenced
this pull request
Nov 22, 2023
pendulum2.x does not support PEP517 and won't build in python3.12, there's a ticket asking for a release to make it compatible with python 3.12 python-pendulum/pendulum#765 the project maintainers have commented on this ticket to say v2 will no longer get updates https://github.com/sdispater/pendulum/issues/753\#issuecomment-1739202965 version3 has pre-releases available on github https://github.com/sdispater/pendulum/releases/tag/3.0.0b1 this commit is now tracking the beta releases to see if there are any issues with our existing code, and will join back with the stable v3 release as it becomes available for large portion of it this should address our requirement for python3.12 note that the Dockerfile is update to track patch releases of the python image REFS #86
|
Pendulum 3.0 is now released, so this won't be needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #696. This implements the lowest effort solution, adding setuptools as a build dependency on Python 3.12 and later, which injects distutils automatically back into the environment for
compatibility. I’ll leave it to the maintainers to decide whether it is worthwhile to maintain this separately from Pendulum 3.