Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider releasing Pendulum 3 or 2.1.2 with patches #753

Closed
bolkedebruin opened this issue Sep 28, 2023 · 6 comments
Closed

Consider releasing Pendulum 3 or 2.1.2 with patches #753

bolkedebruin opened this issue Sep 28, 2023 · 6 comments

Comments

@bolkedebruin
Copy link
Contributor

Hi!

I am one of the Apache Airflow maintainers. Apache Airflow is heavily reliant on Pendulum for its timezone support and we are very grateful for the service that it provides. However, with the latest release of Pendulum stemming from July 2020 we are seeing that issues, like [1], are starting to pop up due to stale timezone data. Being correct was always one of the strengths of Pendulum. Unfortunately, at this moment it is not anymore.

We understand that maintaining a project like this can take a significant amount of time. We see that an alpha has been releases of Pendulum 3, but cannot judge how far off a full release is. Should we start testing Pendulum 3 as part of our code base? Or, considering, our main pain point at this moment is outdated timezone information (there are other nits), is it smarter to backport support for system provided zoneinfo as in this commit [1] or potentially like [2] into Pendulum 2?

So how can we help?

[1] apache/airflow#30467
[2] ae2c9f5
[3] #706

@sdispater @Secrus

@Secrus
Copy link
Collaborator

Secrus commented Sep 28, 2023

Hi. We are working on 3.0 release. See #600 (comment) for more details. We do not plan to release any more 2.x versions AFAIK.

@bolkedebruin
Copy link
Contributor Author

I understand you are working on it, the question is can we help in anyway to speed things up? The last alpha release was from November 2022, so I assume significant changes have been made in the meantime.

@mattsta
Copy link

mattsta commented Oct 15, 2023

We're in the same boat here.

We switched a dozen internal services from arrow to Pendulum in 2021, but now we're stuck not being able to upgrade to Python 3.12 because Pendulum 2.x isn't happy unless we upgrade with --pre.

3.12.0 build failure output with the current pypi release:

Collecting pendulum
  Downloading pendulum-2.1.2.tar.gz (81 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 81.2/81.2 kB 6.0 MB/s eta 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Collecting pytzdata>=2020.1 (from pendulum)
  Downloading pytzdata-2020.1-py2.py3-none-any.whl (489 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 490.0/490.0 kB 23.1 MB/s eta 0:00:00
Building wheels for collected packages: pendulum
  Building wheel for pendulum (pyproject.toml) ... error
  error: subprocess-exited-with-error
  
  × Building wheel for pendulum (pyproject.toml) did not run successfully.
   exit code: 1
  ╰─> [27 lines of output]
      Traceback (most recent call last):
        File "/private/var/folders/sk/zncv9ddn375grsn9fddr0hj00000gn/T/pip-install-dvqbja46/pendulum_bb6d1c36847d4ef9887f7927387d1b8f/build.py", line 5, in <module>
          from distutils.command.build_ext import build_ext
      ModuleNotFoundError: No module named 'distutils'
    
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for pendulum
Failed to build pendulum
ERROR: Could not build wheels for pendulum, which is required to install pyproject.toml-based projects

@bolkedebruin
Copy link
Contributor Author

bolkedebruin commented Nov 17, 2023

@Secrus @sdispater bumping this thread. We are getting in a tough situation with Apache Airflow. Pendulum 2 has issues with:

  • Python 3.12
  • Memory leaks
  • Outdated timezone information

Pendulum 3 fixes those issues and we do not mind moving towards it. We have a PR open for it, but there are some outstanding prs / issues with the beta, like:

They are not getting addressed or merged. The roadmap forward is getting foggy!

Can we do anything to help? Can others be allowed to merge changes if the bandwidth isn't available?

devraj referenced this issue in anomaly/lab-python-server Nov 22, 2023
pendulum2.x does not support PEP517 and won't build in python3.12, there's a ticket
asking for a release to make it compatible with python 3.12
python-pendulum/pendulum#765

the project maintainers have commented on this ticket to say v2 will no longer get updates
https://github.com/sdispater/pendulum/issues/753\#issuecomment-1739202965

version3 has pre-releases available on github
https://github.com/sdispater/pendulum/releases/tag/3.0.0b1

this commit is now tracking the beta releases to see if there are any issues with
our existing code, and will join back with the stable v3 release as it becomes available

for large portion of it this should address our requirement for python3.12

note that the Dockerfile is update to track patch releases of the python image

REFS #86
@bolkedebruin
Copy link
Contributor Author

Friendly ping @sdispater see also #771

@Secrus
Copy link
Collaborator

Secrus commented Dec 17, 2023

Pendulum 3.0 was released.

@Secrus Secrus closed this as completed Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants