Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clarification about timezone aware dags #30467

Merged
merged 2 commits into from
Apr 5, 2023
Merged

add clarification about timezone aware dags #30467

merged 2 commits into from
Apr 5, 2023

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented Apr 4, 2023

I've heard from several users that recent time change in Mexico caused DAGs not to run as expected.
This PR add clarification about such cases.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@o-nikolas o-nikolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I left a suggestion for some minor grammar/wording nits if you'd like to accept it, but no pressure 👍

docs/apache-airflow/authoring-and-scheduling/timezone.rst Outdated Show resolved Hide resolved
@eladkal eladkal added this to the Airflow 2.5.4 milestone Apr 5, 2023
@eladkal eladkal added the type:doc-only Changelog: Doc Only label Apr 5, 2023
@eladkal eladkal merged commit 3f7541b into apache:main Apr 5, 2023
@eladkal eladkal deleted the mx branch April 5, 2023 08:42
@notatallshaw-gts
Copy link
Contributor

notatallshaw-gts commented Apr 5, 2023

Sorry to comment on a merged PR but it appears to be the issue is there is no released version of Pendulum which includes the recent changes to DST in Mexico. Some discussion has started happening here python-pendulum/pendulum#700.

Also it's not clear to me that if your tzinfo is up to date and you pass in a timezone aware start date that respects Mexico's DST, would Airflow act correctly or because it heavily relies on Pendulum would it still schedule at the wrong time?

@eladkal
Copy link
Contributor Author

eladkal commented Apr 12, 2023

Sorry to comment on a merged PR but it appears to be the issue is there is no released version of Pendulum which includes the recent changes to DST in Mexico.

Thus this is upstream library problem, nothing we can do about it other than waiting for them to fix it.
Once they will issue a release with a fix it will be up to Airflow to see how we can migrate to the new release as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants