Skip to content

Commit

Permalink
fix: python3.12 build by upgrading pendulum3-beta
Browse files Browse the repository at this point in the history
pendulum2.x does not support PEP517 and won't build in python3.12, there's a ticket
asking for a release to make it compatible with python 3.12
python-pendulum/pendulum#765

the project maintainers have commented on this ticket to say v2 will no longer get updates
https://github.com/sdispater/pendulum/issues/753\#issuecomment-1739202965

version3 has pre-releases available on github
https://github.com/sdispater/pendulum/releases/tag/3.0.0b1

this commit is now tracking the beta releases to see if there are any issues with
our existing code, and will join back with the stable v3 release as it becomes available

for large portion of it this should address our requirement for python3.12

note that the Dockerfile is update to track patch releases of the python image

REFS #86
  • Loading branch information
devraj committed Nov 22, 2023
1 parent 37e1ba9 commit a830530
Show file tree
Hide file tree
Showing 5 changed files with 183 additions and 51 deletions.
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# While optional this tells the Docker builder of the version
# syntax=docker/dockerfile:1
ARG PYTHON_VERSION=3.11.4-slim-bullseye
ARG PYTHON_VERSION=3.12-bookworm

# Base image for Python applications
# This image is particularly for a web server using uvicorn
Expand Down Expand Up @@ -44,4 +44,4 @@ WORKDIR /opt/
# Labels are used to identify the image
LABEL org.opencontainers.image.source="https://github.com/anomaly/${PROJ_NAME}"
LABEL org.opencontainers.image.description="A Python web server using FastAPI and Uvicorn"
LABEL org.opencontainers.image.licenses="Apache-2.0"
LABEL org.opencontainers.image.licenses="Apache-2.0"
4 changes: 2 additions & 2 deletions Dockerfile.prod
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# While optional this tells the Docker builder of the version
# syntax=docker/dockerfile:1
#
ARG PYTHON_VERSION=3.11.1-slim-bullseye
ARG PYTHON_VERSION=3.12-bookworm

# This Dockerfile uses a multi stage build to slim down the image
# https://docs.docker.com/develop/develop-images/multistage-build/
Expand Down Expand Up @@ -76,4 +76,4 @@ EXPOSE 80
# Labels are used to identify the image
LABEL org.opencontainers.image.source="https://github.com/anomaly/${PROJ_NAME}"
LABEL org.opencontainers.image.description="A Python web server using FastAPI and Uvicorn"
LABEL org.opencontainers.image.licenses="Apache-2.0"
LABEL org.opencontainers.image.licenses="Apache-2.0"
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ services:
# RabbitMQ:
# TaskIQ recommend using rabbitmq for the broker
rabbitmq:
image: rabbitmq:3.11-management
image: rabbitmq:3.12-management
container_name: ${PROJ_NAME}-rabbitmq
restart: unless-stopped
env_file:
Expand Down
Loading

0 comments on commit a830530

Please sign in to comment.