Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure resource and invoke option "version" is used in package resolution #423

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

AaronFriel
Copy link
Contributor

@AaronFriel AaronFriel commented Dec 7, 2022

Updates Pulumi YAML to target latest Pulumi branch.

Resource option "version" is now passed down into the schema loader for type checking, and setting default providers overrides the version option on resources and invokes ensuring that the version is applied through convert.

Adds an example to validate this behavior.

Recommend reviewing by commit, they're broken down by chore vs feature work.

Fixes #414, #421, #422.

Copy link
Contributor

@aq17 aq17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AaronFriel AaronFriel force-pushed the friel/optimistic-resolution branch from beb844f to 6c48353 Compare December 7, 2022 17:31
@AaronFriel AaronFriel force-pushed the friel/optimistic-resolution branch from 6c48353 to 4055023 Compare December 7, 2022 18:06
@AaronFriel AaronFriel merged commit 3abcc76 into main Dec 7, 2022
@AaronFriel AaronFriel deleted the friel/optimistic-resolution branch December 7, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beta plugin versions are used over stable versions
2 participants