Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulumi convert only converts Outputs #422

Closed
guineveresaenger opened this issue Dec 6, 2022 · 1 comment
Closed

pulumi convert only converts Outputs #422

guineveresaenger opened this issue Dec 6, 2022 · 1 comment
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone

Comments

@guineveresaenger
Copy link

What happened?

I have a YAML source file:

name: image-yaml
description: A minimal Pulumi YAML program
runtime: yaml
config: {}
variables: {}
resources:
  guins-image:
    type: docker:Image
    properties:
      imageName: gsaenger/test-yaml:tag1
      skipPush: true
      build:
        dockerfile: Dockerfile
        context: .
outputs:
  imageName: ${guins-image.imageName}

I ran the following:

$ pulumi convert --language typescript --out ts-image
$ cat ts-image/index.ts 
import * as pulumi from "@pulumi/pulumi";

export const imageName = guinsImage.imageName;

Steps to reproduce

Create a Pulumi YAML file with the above content.
Run pulumi convert as above.

Expected Behavior

I would expect my index.ts to look something like this:

import * as pulumi from "@pulumi/pulumi";
const img = new docker.Image("guins-image", {
        imageName: "gsaenger/test-yaml:tag1",
        skipPush: true,
        build: {
           context: ".",
           dockerfile: "Dockerfile",
         }
export const imageName = guinsImage.imageName;

Actual Behavior

Only dependency and package output is generated:

import * as pulumi from "@pulumi/pulumi";

export const imageName = guinsImage.imageName;

Output of pulumi about

n/a

Additional context

PCL also generates only the output block

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@guineveresaenger guineveresaenger added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Dec 6, 2022
bors bot added a commit to pulumi/pulumi that referenced this issue Dec 7, 2022
11570: testing: Allow plugin testing users to define their own plugin sets r=AaronFriel a=AaronFriel

Updating Pulumi YAML to address pulumi/pulumi-yaml#421 and pulumi/pulumi-yaml#422, requires testing against the Docker v4.0.0-alpha.0 schema. That required updating this repo, and using Go workspaces/module replacement to allow the deploytest plugin loader to find the prerelease schema.

This change allows Pulumi YAML to define its own set of required plugins, decoupling the two repos and preventing the catch-22 here.

Because this repo will need to support the new example being authored which will serve as a test of #421 and #422, this also adds Docker v4.0.0-alpha.0 as a schema.

Co-authored-by: Aaron Friel <[email protected]>
bors bot added a commit to pulumi/pulumi that referenced this issue Dec 7, 2022
11570: testing: Allow plugin testing users to define their own plugin sets r=AaronFriel a=AaronFriel

Updating Pulumi YAML to address pulumi/pulumi-yaml#421 and pulumi/pulumi-yaml#422, requires testing against the Docker v4.0.0-alpha.0 schema. That required updating this repo, and using Go workspaces/module replacement to allow the deploytest plugin loader to find the prerelease schema.

This change allows Pulumi YAML to define its own set of required plugins, decoupling the two repos and preventing the catch-22 here.

Because this repo will need to support the new example being authored which will serve as a test of #421 and #422, this also adds Docker v4.0.0-alpha.0 as a schema.

Co-authored-by: Aaron Friel <[email protected]>
@justinvp justinvp removed the needs-triage Needs attention from the triage team label Dec 7, 2022
@aq17 aq17 added the resolution/fixed This issue was fixed label Dec 7, 2022
@aq17
Copy link
Contributor

aq17 commented Dec 7, 2022

Fixed via #423

@aq17 aq17 closed this as completed Dec 7, 2022
@AaronFriel AaronFriel self-assigned this Dec 9, 2022
@AaronFriel AaronFriel added this to the 0.82 milestone Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

4 participants