Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow docker:Image as a resource for docker v4+ #421

Closed
guineveresaenger opened this issue Dec 6, 2022 · 2 comments
Closed

Allow docker:Image as a resource for docker v4+ #421

guineveresaenger opened this issue Dec 6, 2022 · 2 comments
Assignees
@AaronFriel
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone
0.82

Comments

@guineveresaenger
Copy link

guineveresaenger commented Dec 6, 2022 •
edited by AaronFriel
Loading

YAML workaround

To use Docker image resources, declare a default provider to use the v4 provider:

resources:
  docker-provider:
    type: pulumi:providers:docker
    defaultProvider: true
    options:
      version: 4.0.0-alpha.0

Refer to https://github.com/pulumi/pulumi-docker for the latest release version(s).

Currently we disallow Docker Image resource from being used with yaml.

As of pulumi-docker v4.0, this resource is schematized and therefore YAML compatible.

It was suggested we remove the error in favor of a warning, letting users know this resource will not work in YAML for pulumi-docker v3.x and lower.
@AaronFriel AaronFriel mentioned this issue Dec 7, 2022
Merged
bors bot added a commit to pulumi/pulumi that referenced this issue Dec 7, 2022
@bors @AaronFriel
Merge #11570
65f2d14 
11570: testing: Allow plugin testing users to define their own plugin sets r=AaronFriel a=AaronFriel

Updating Pulumi YAML to address pulumi/pulumi-yaml#421 and pulumi/pulumi-yaml#422, requires testing against the Docker v4.0.0-alpha.0 schema. That required updating this repo, and using Go workspaces/module replacement to allow the deploytest plugin loader to find the prerelease schema.

This change allows Pulumi YAML to define its own set of required plugins, decoupling the two repos and preventing the catch-22 here.

Because this repo will need to support the new example being authored which will serve as a test of #421 and #422, this also adds Docker v4.0.0-alpha.0 as a schema.

Co-authored-by: Aaron Friel <[email protected]>
@AaronFriel
Copy link
Contributor

AaronFriel commented Dec 7, 2022 •
edited
Loading

@guineveresaenger I've added workaround information to the top of this issue while I work on a change to address. That workaround isn't valid yet, but will be when the PR which adds an error message referencing it is merged.

bors bot added a commit to pulumi/pulumi that referenced this issue Dec 7, 2022
@bors @AaronFriel
Merge #11570
e812f69 
11570: testing: Allow plugin testing users to define their own plugin sets r=AaronFriel a=AaronFriel

Updating Pulumi YAML to address pulumi/pulumi-yaml#421 and pulumi/pulumi-yaml#422, requires testing against the Docker v4.0.0-alpha.0 schema. That required updating this repo, and using Go workspaces/module replacement to allow the deploytest plugin loader to find the prerelease schema.

This change allows Pulumi YAML to define its own set of required plugins, decoupling the two repos and preventing the catch-22 here.

Because this repo will need to support the new example being authored which will serve as a test of #421 and #422, this also adds Docker v4.0.0-alpha.0 as a schema.

Co-authored-by: Aaron Friel <[email protected]>
@AaronFriel AaronFriel mentioned this issue Dec 7, 2022
Merged
@aq17 aq17 added resolution/fixed This issue was fixed kind/enhancement Improvements or new features labels Dec 7, 2022
@aq17
Copy link
Contributor

aq17 commented Dec 7, 2022

Fixed via #423

@aq17 aq17 closed this as completed Dec 7, 2022
@AaronFriel AaronFriel added this to the 0.82 milestone Dec 9, 2022
@AaronFriel AaronFriel self-assigned this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AaronFriel AaronFriel

Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.82
Development

No branches or pull requests
3 participants
@AaronFriel @guineveresaenger @aq17