-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore input changes to username and password #498
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good. I'm not an expert on Docker, but this feels like a place where people will have different expectations. Before merging, can we
- Document this change in the schema.
- Add a test that demonstrates what the intended behavior is.
Does the PR have any schema changes?Looking good! No breaking changes found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a docs fix.
Co-authored-by: Aaron Friel <[email protected]>
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look good, thanks for adding those.
The registry auth credentials can rotate frequently, depending on the container registry.
A rebuild and push should not be triggered if these fields are the only inputs that changed between updates.
This PR checks the
registry
input fields and only notes an rpc diff response if theserver
property is different.Note that any edits to the docker build context will still trigger a rebuild - this change only affects changes to the underlying values of username and password.
Fixes #484.