Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore changes to username and password in Diff() #484

Closed
guineveresaenger opened this issue Feb 8, 2023 · 1 comment · Fixed by #498
Closed

Ignore changes to username and password in Diff() #484

guineveresaenger opened this issue Feb 8, 2023 · 1 comment · Fixed by #498
Assignees
@guineveresaenger
Labels
4.x.x kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone
0.85

Comments

@guineveresaenger
Copy link
Contributor

As login credentials can change frequently, it should not be necessary to re-build the image every time this happens.

We should ignore these if they are the only changes in Diff().
@guineveresaenger guineveresaenger added 4.x.x kind/enhancement Improvements or new features labels Feb 8, 2023
@kmosher
Copy link

kmosher commented Feb 10, 2023

Tried using the ignoreChanges resource option to paper over this, but then the creds simply never get updated and end up expiring.

@guineveresaenger guineveresaenger self-assigned this Feb 14, 2023
@guineveresaenger guineveresaenger mentioned this issue Feb 14, 2023
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Feb 15, 2023
@mikhailshilkov mikhailshilkov added this to the 0.85 milestone Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guineveresaenger guineveresaenger

Labels
4.x.x kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.85
Development

Successfully merging a pull request may close this issue.

Ignore input changes to username and password pulumi/pulumi-docker
4 participants
@kmosher @mikhailshilkov @guineveresaenger @pulumi-bot