Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore input changes to username and password #498

Merged
merged 7 commits into from
Feb 15, 2023
Merged

Ignore input changes to username and password #498

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2cff179
Intercept registry diff and handle its fields as a first pass at bett…
guineveresaenger Feb 13, 2023
f5452ab
Return NONE for diffResponse if the only updates are to usernae or pa…
guineveresaenger Feb 14, 2023
a7a8770
Separate out detailed diff functionality in separate function for uni…
guineveresaenger Feb 14, 2023
53a860a
Add unit test for diffUpdates
guineveresaenger Feb 14, 2023
95f96d0
Add documentation
guineveresaenger Feb 14, 2023
91fd784
Typos in docs line
guineveresaenger Feb 14, 2023
5038661
Regenerate schema and SDKs
guineveresaenger Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions provider/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,29 @@ func (p *dockerNativeProvider) Diff(ctx context.Context, req *rpc.DiffRequest) (
for key := range d.Deletes {
diff[string(key)] = &rpc.PropertyDiff{Kind: rpc.PropertyDiff_DELETE}
}
for key := range d.Updates {
diff[string(key)] = &rpc.PropertyDiff{Kind: rpc.PropertyDiff_UPDATE}

for key, valueDiff := range d.Updates {
if string(key) != "registry" {
diff[string(key)] = &rpc.PropertyDiff{
Kind: rpc.PropertyDiff_UPDATE,
}
} else {
// only register a diff on "server" field, but not on "username" or "password",
// as they can change frequently and should not trigger a rebuild.
serverDiff := valueDiff.Object.Updates["server"]
// if serverDiff is not empty, we register a property diff update
if serverDiff != (resource.ValueDiff{}) {
diff[string(key)] = &rpc.PropertyDiff{
Kind: rpc.PropertyDiff_UPDATE,
}
}
}
}
// if diff is empty, it means we skipped any changes to username and password
if len(diff) == 0 {
return &rpc.DiffResponse{
Changes: rpc.DiffResponse_DIFF_NONE,
}, nil
}
return &rpc.DiffResponse{
Changes: rpc.DiffResponse_DIFF_SOME,
Expand Down