treewide: Bump AXI-RT and fix AXI-RT functional tests #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex96295
force-pushed
the
aottaviano/realm-eval
branch
from
65d53fd to
6f78017
Compare
Aquaticfuller
pushed a commit
that referenced
this pull request
Jul 16, 2024
Bender: Bump `axi_rt` AXI real-time unit
alex96295
force-pushed
the
aottaviano/realm-eval
branch
2 times, most recently
from
321dcd6 to
e465b87
Compare
alex96295
force-pushed
the
aottaviano/realm-eval
branch
4 times, most recently
from
1fd8e20 to
82b64c4
Compare
alex96295
changed the title
paulsc96
requested changes
Oct 23, 2024
There was a problem hiding this comment.
I can't speak on the tests, it's best to talk that over with @thommythomaso.
The nonfree change is fine and has been merged.
I just have one small comment below.
paulsc96
reviewed
Nov 14, 2024
* Fix functional bug
alex96295
force-pushed
the
aottaviano/realm-eval
branch
2 times, most recently
from
00d3c10 to
757b7ec
Compare
This parameter in the makefrag affects the number of registers generated inside the AXI-REALM IP. The default value, associated with the default configuration of Cheshire, is 6, accounting for: `core0`, `debug module`, `dma`, `serial link`, `vga` and `usb`. Change accordingly if the configuration changes, e.g., the number of cores or if new managers are added.
Add utility function to get the manager id of cheshire according to the implemented HW features, thus removing any hardcoded parametrization (the number of application-class cores, as well as the specific hardware features, are configurable, hence not known a priori)
* Fix check on budget left for W and R transactions
Test that the manager is isolated when the transfer size exceeds the available budget
* Add AXI-REALM isolation test to CI
alex96295
force-pushed
the
aottaviano/realm-eval
branch
from
757b7ec to
014049b
Compare
paulsc96
force-pushed
the
aottaviano/realm-eval
branch
6 times, most recently
from
66df1ca to
1f54560
Compare
paulsc96
force-pushed
the
aottaviano/realm-eval
branch
from
1f54560 to
9e5cc9b
Compare
paulsc96
force-pushed
the
aottaviano/realm-eval
branch
from
1fc09f2 to
d7e1176
Compare
paulsc96
force-pushed
the
aottaviano/realm-eval
branch
from
39a5937 to
c372247
Compare
paulsc96
previously approved these changes
Nov 28, 2024
paulsc96
changed the title
paulsc96
force-pushed
the
aottaviano/realm-eval
branch
from
5a0e495 to
d4adb6d
Compare
paulsc96
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump AXI-REALM to latest version. Fixes functional bug in the write buffer module (Various fixes and improvements axi_rt#11).
Fix default number of configuration registers in
cheshire.mkFix budget (W/R) left check in
axirt_budget.ctestAdd
axirt_budget_isolation.ctest to check manager isolation through AXI-REALM after budget expires (transfer size > budget)Further additions:
tclintversion to 0.4.2CHSROOTto staticrealpath(pwdmay not be a fully qualified path)helloworldtests