Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sw/tests: Add basic CLIC tests #165

Merged
merged 4 commits into from
Nov 28, 2024
Merged

sw/tests: Add basic CLIC tests #165

merged 4 commits into from
Nov 28, 2024

Conversation

niwis
Copy link
Contributor

@niwis niwis commented Nov 14, 2024

Add two basic CLIC tests and add them to CI.

paulsc96
paulsc96 previously approved these changes Nov 14, 2024
Copy link
Collaborator

@paulsc96 paulsc96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍 Just to be sure: Did you try to provoke a failure to see if the tests works as intended? (SW tests are tricky).

Unfortunately I made the mistake of merging the nonfree commit of #118 early, so that will have to be merged first :S sorry

@paulsc96 paulsc96 added this to the v0.2.0 milestone Nov 14, 2024
@niwis
Copy link
Contributor Author

niwis commented Nov 15, 2024

Of course! see here for an intentionally failing run. This is good to go from my side; I'm marking the PR as ready for review. Let me know if I should rebase after #118 is merged.

@niwis niwis marked this pull request as ready for review November 15, 2024 04:18
Copy link
Collaborator

@paulsc96 paulsc96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...well, oops. Better late than never 😅 auto merge engaged.

@paulsc96 paulsc96 merged commit 97fddf4 into main Nov 28, 2024
16 of 18 checks passed
@paulsc96 paulsc96 deleted the nw/ci-clic branch November 28, 2024 22:38
@paulsc96
Copy link
Collaborator

...and I just keep failing. That should have waited for checks to pass. Oh well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants