-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mediago support prebid server #5395
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dev-docs/bidders/mediago.md
Outdated
@@ -3,11 +3,14 @@ layout: bidder | |||
title: MediaGo | |||
description: MediaGo Prebid Bidder Adapter | |||
biddercode: mediago | |||
media_types: banner | |||
media_types: banner,native | |||
prebid_member: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't Baidu a member company now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisHuie We did join the prebid.org Slack group. But I'm not so sure if that means we are members.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked with my colleague, and we confirmed that we are members. I will update the code accordingly.
dev-docs/bidders/mediago.md
Outdated
@@ -26,7 +29,8 @@ The MediaGo Bidding adapter requires setup before beginning. Please contact us a | |||
{: .table .table-bordered .table-striped } | |||
| Name | Scope | Description | Example | Type | | |||
|---------------|----------|-----------------------|-----------|-----------| | |||
| `token` | required | publisher token | `'1e100887dd614b7f69fdd1360437'` | `string` | | |||
| `token` | required | publisher token, This parameter expects all imps to be the same | `'1e100887dd614b7f69fdd1360437'` | `string` | | |||
| `region` | recommend | Server region for PBS request: US for US Region, EU for EU Region, APAC for APAC Region, default is US. This parameter expects all imps to be the same. | `'US'` | `string` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mark this parameter as being available for PBS only. Apparently the "test" and "bidfloor" parameters are PBJS only. (though we'd prefer you got rid of the bidfloor param and just read the floor in the standard way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bretg Thanks for your advice. I have changed it.
* mediago support prebid server * MediaGo Baidu is Prebid member * mark parameters' availability
🏷 Type of documentation
new bid adapter
update bid adapter
Add MediaGo server adapter.
new feature
text edit only (wording, typos)
bugfix (code examples)
new examples
📋 Checklist
Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
The PR is here: New Adapter : MediaGo prebid-server#3705
For new adapters check submitting your adapter docs